From: Dan Carpenter <error27@gmail.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@suse.de>,
"Frederik Deweerdt" <frederik.deweerdt@xprog.eu>,
"Tejun Heo" <tj@kernel.org>, "Stoyan Gaydarov" <sgayda2@uiuc.edu>,
"Németh Márton" <nm127@freemail.hu>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: line6: fix leaks in line6_probe()
Date: Mon, 12 Jul 2010 16:19:16 +0000 [thread overview]
Message-ID: <20100712161916.GB5658@bicker> (raw)
In-Reply-To: <1278946051-30118-1-git-send-email-segooon@gmail.com>
On Mon, Jul 12, 2010 at 06:47:30PM +0400, Kulikov Vasiliy wrote:
> - if (ret < 0) {
> - line6_destruct(interface);
> - return ret;
> - }
> + if (ret < 0)
> + goto err_put;
This should be:
goto err_destruct;
regards,
dan carpenter
>
> dev_info(&interface->dev, "Line6 %s now attached\n",
> line6->properties->name);
> line6_devices[devnum] = line6;
> line6_list_devices();
> + return 0;
> +
> +err_destruct:
> + line6_destruct(interface);
> +err_put:
> + usb_put_intf(interface);
> + usb_put_dev(usbdev);
> return ret;
> }
>
prev parent reply other threads:[~2010-07-12 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 14:47 [PATCH] Staging: line6: fix leaks in line6_probe() Kulikov Vasiliy
2010-07-12 16:19 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100712161916.GB5658@bicker \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=frederik.deweerdt@xprog.eu \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm127@freemail.hu \
--cc=segooon@gmail.com \
--cc=sgayda2@uiuc.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox