* [PATCH 09/11] staging: msm: formatting of pointers in printk()
@ 2010-07-14 18:05 Kulikov Vasiliy
2010-07-14 18:21 ` Joe Perches
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kulikov Vasiliy @ 2010-07-14 18:05 UTC (permalink / raw)
To: kernel-janitors
Cc: Greg Kroah-Hartman, Dominik Brodowski, Alexander Kurz,
Jiri Kosina, Javier Martinez Canillas, devel, linux-kernel
Use %p instead of %08x in printk().
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
index 8d16380..8b49cb1 100644
--- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
+++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
@@ -208,7 +208,7 @@ static void hex_dump(char *str, void *ptr, int len)
for (i = 0; i < len; i++) {
if (i % 16 = 0)
- printk("\n0x%08x:", (unsigned int)cptr);
+ printk("\n%p:", cptr);
printk(" %02x", *(cptr++));
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 09/11] staging: msm: formatting of pointers in printk()
2010-07-14 18:05 [PATCH 09/11] staging: msm: formatting of pointers in printk() Kulikov Vasiliy
@ 2010-07-14 18:21 ` Joe Perches
2010-07-14 20:36 ` Greg KH
2010-07-14 22:32 ` David Brown
2 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2010-07-14 18:21 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: kernel-janitors, Greg Kroah-Hartman, Dominik Brodowski,
Alexander Kurz, Jiri Kosina, Javier Martinez Canillas, devel,
linux-kernel
On Wed, 2010-07-14 at 22:05 +0400, Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> index 8d16380..8b49cb1 100644
> --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> @@ -208,7 +208,7 @@ static void hex_dump(char *str, void *ptr, int len)
>
> for (i = 0; i < len; i++) {
> if (i % 16 = 0)
> - printk("\n0x%08x:", (unsigned int)cptr);
> + printk("\n%p:", cptr);
>
> printk(" %02x", *(cptr++));
> }
I was originally going to suggest a conversion
to print_hex_dump, but this function isn't used
and it and daqp_dump might as well be removed.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 09/11] staging: msm: formatting of pointers in printk()
2010-07-14 18:05 [PATCH 09/11] staging: msm: formatting of pointers in printk() Kulikov Vasiliy
2010-07-14 18:21 ` Joe Perches
@ 2010-07-14 20:36 ` Greg KH
2010-07-14 22:32 ` David Brown
2 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2010-07-14 20:36 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: kernel-janitors, Dominik Brodowski, Alexander Kurz, Jiri Kosina,
Javier Martinez Canillas, devel, linux-kernel
On Wed, Jul 14, 2010 at 10:05:17PM +0400, Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
Why does your Subject: say "msm"?
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 09/11] staging: msm: formatting of pointers in printk()
2010-07-14 18:05 [PATCH 09/11] staging: msm: formatting of pointers in printk() Kulikov Vasiliy
2010-07-14 18:21 ` Joe Perches
2010-07-14 20:36 ` Greg KH
@ 2010-07-14 22:32 ` David Brown
2 siblings, 0 replies; 4+ messages in thread
From: David Brown @ 2010-07-14 22:32 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: kernel-janitors, Greg Kroah-Hartman, Dominik Brodowski,
Alexander Kurz, Jiri Kosina, Javier Martinez Canillas, devel,
linux-kernel
On Wednesday 14 July 2010 11:05:17 Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
Did you mean to have an 'msm:' in the subject? This driver isn't part
of the msm subsystem?
Thanks,
David Brown
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-07-14 22:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-14 18:05 [PATCH 09/11] staging: msm: formatting of pointers in printk() Kulikov Vasiliy
2010-07-14 18:21 ` Joe Perches
2010-07-14 20:36 ` Greg KH
2010-07-14 22:32 ` David Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).