From: "Peter Hüwe" <PeterHuewe@gmx.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: Convert pci_table entries with PCI_ANY_ID to PCI_DEVICE ?
Date: Thu, 15 Jul 2010 13:57:37 +0000 [thread overview]
Message-ID: <201007151557.37555.PeterHuewe@gmx.de> (raw)
In-Reply-To: <201007151550.42146.PeterHuewe@gmx.de>
Or even better convert them using PCI_VDEVICE,
Here's the same sample patch with PCI_VDEVICE:
---
diff --git a/arch/x86/kernel/cpu/cpufreq/gx-suspmod.c
b/arch/x86/kernel/cpu/cpufreq/gx-suspmod.c
index 16e3483..581b29c 100644
--- a/arch/x86/kernel/cpu/cpufreq/gx-suspmod.c
+++ b/arch/x86/kernel/cpu/cpufreq/gx-suspmod.c
@@ -169,12 +169,9 @@ static int gx_freq_mult[16] = {
* Low Level chipset interface *
****************************************************************/
static struct pci_device_id gx_chipset_tbl[] __initdata = {
- { PCI_VENDOR_ID_CYRIX, PCI_DEVICE_ID_CYRIX_5530_LEGACY,
- PCI_ANY_ID, PCI_ANY_ID },
- { PCI_VENDOR_ID_CYRIX, PCI_DEVICE_ID_CYRIX_5520,
- PCI_ANY_ID, PCI_ANY_ID },
- { PCI_VENDOR_ID_CYRIX, PCI_DEVICE_ID_CYRIX_5510,
- PCI_ANY_ID, PCI_ANY_ID },
+ { PCI_VDEVICE(CYRIX, PCI_DEVICE_ID_CYRIX_5530_LEGACY) },
+ { PCI_VDEVICE(CYRIX, PCI_DEVICE_ID_CYRIX_5520) },
+ { PCI_VDEVICE(CYRIX, PCI_DEVICE_ID_CYRIX_5510) },
{ 0, },
};
---
What do you think?
prev parent reply other threads:[~2010-07-15 13:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 13:50 Convert pci_table entries with PCI_ANY_ID to PCI_DEVICE ? Peter Hüwe
2010-07-15 13:57 ` Peter Hüwe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007151557.37555.PeterHuewe@gmx.de \
--to=peterhuewe@gmx.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox