From mboxrd@z Thu Jan  1 00:00:00 1970
From: Giuliano Pochini <pochini@shiny.it>
Date: Fri, 16 Jul 2010 19:16:50 +0000
Subject: Re: [PATCH 11/15] pci: echoaudio: check kmalloc() result
Message-Id: <20100716211650.4abb6387@Jay>
List-Id: <kernel-janitors.vger.kernel.org>
References: <1279296943-25187-1-git-send-email-segooon@gmail.com>
In-Reply-To: <1279296943-25187-1-git-send-email-segooon@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>, Julia Lawall <julia@diku.dk>, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org

On Fri, 16 Jul 2010 20:15:43 +0400
Kulikov Vasiliy <segooon@gmail.com> wrote:

> If kmalloc() fails exit with -ENOMEM.
> 
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
>  sound/pci/echoaudio/echoaudio.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c
> index 668a5ec..20763dd 100644
> --- a/sound/pci/echoaudio/echoaudio.c
> +++ b/sound/pci/echoaudio/echoaudio.c
> @@ -2250,6 +2250,8 @@ static int snd_echo_resume(struct pci_dev *pci)
>  	DE_INIT(("resume start\n"));
>  	pci_restore_state(pci);
>  	commpage_bak = kmalloc(sizeof(struct echoaudio), GFP_KERNEL);
> +	if (commpage_bak = NULL)
> +		return -ENOMEM;
>  	commpage = chip->comm_page;
>  	memcpy(commpage_bak, commpage, sizeof(struct comm_page));
>  

Yes, of course. Thank you.


Ack-by: Giuliano Pochini <pochini@shiny.it>


-- 
Giuliano.