kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] auditsc: audit_log_single_execve_arg() returns signed
@ 2010-07-17 10:26 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2010-07-17 10:26 UTC (permalink / raw)
  To: Al Viro; +Cc: Eric Paris, linux-kernel, kernel-janitors

"len" needs to be signed because audit_log_single_execve_arg() returns
-1 and we want to check for that:

                len = audit_log_single_execve_arg(context, ab, i,
                                                  &len_sent, p, buf);
                if (len <= 0)
                        break;

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index 3828ad5..2c060c3 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -1158,7 +1158,8 @@ static void audit_log_execve_info(struct audit_context *context,
 				  struct audit_aux_data_execve *axi)
 {
 	int i;
-	size_t len, len_sent = 0;
+	ssize_t len;
+	size_t len_sent = 0;
 	const char __user *p;
 	char *buf;
 

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-07-17 10:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-17 10:26 [patch] auditsc: audit_log_single_execve_arg() returns signed Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).