* [PATCH 13/15] sound/soc: davinci: check kzalloc() result (typo)
@ 2010-07-16 16:16 Kulikov Vasiliy
2010-07-17 17:45 ` Liam Girdwood
0 siblings, 1 reply; 3+ messages in thread
From: Kulikov Vasiliy @ 2010-07-16 16:16 UTC (permalink / raw)
To: kernel-janitors
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Peter Ujfalusi, Miguel Aguilar, alsa-devel, linux-kernel
The code checks 'davinci_vc' after kzalloc() and do not checks
'davinci_vcif_dev' that kzalloc() result is assigned to. It seems that
it is a typo (autocompletion?).
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
sound/soc/davinci/davinci-vcif.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/davinci/davinci-vcif.c b/sound/soc/davinci/davinci-vcif.c
index 9aa980d..4867853 100644
--- a/sound/soc/davinci/davinci-vcif.c
+++ b/sound/soc/davinci/davinci-vcif.c
@@ -203,7 +203,7 @@ static int davinci_vcif_probe(struct platform_device *pdev)
int ret;
davinci_vcif_dev = kzalloc(sizeof(struct davinci_vcif_dev), GFP_KERNEL);
- if (!davinci_vc) {
+ if (!davinci_vcif_dev) {
dev_dbg(&pdev->dev,
"could not allocate memory for private data\n");
return -ENOMEM;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 13/15] sound/soc: davinci: check kzalloc() result (typo)
2010-07-16 16:16 [PATCH 13/15] sound/soc: davinci: check kzalloc() result (typo) Kulikov Vasiliy
@ 2010-07-17 17:45 ` Liam Girdwood
2010-07-17 18:47 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Liam Girdwood @ 2010-07-17 17:45 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: alsa-devel, Takashi Iwai, kernel-janitors, Mark Brown,
Peter Ujfalusi, linux-kernel, Miguel Aguilar
On Fri, 2010-07-16 at 20:16 +0400, Kulikov Vasiliy wrote:
> The code checks 'davinci_vc' after kzalloc() and do not checks
> 'davinci_vcif_dev' that kzalloc() result is assigned to. It seems that
> it is a typo (autocompletion?).
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
> sound/soc/davinci/davinci-vcif.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/davinci/davinci-vcif.c b/sound/soc/davinci/davinci-vcif.c
> index 9aa980d..4867853 100644
> --- a/sound/soc/davinci/davinci-vcif.c
> +++ b/sound/soc/davinci/davinci-vcif.c
> @@ -203,7 +203,7 @@ static int davinci_vcif_probe(struct platform_device *pdev)
> int ret;
>
> davinci_vcif_dev = kzalloc(sizeof(struct davinci_vcif_dev), GFP_KERNEL);
> - if (!davinci_vc) {
> + if (!davinci_vcif_dev) {
> dev_dbg(&pdev->dev,
> "could not allocate memory for private data\n");
> return -ENOMEM;
13,14 & 15
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 13/15] sound/soc: davinci: check kzalloc() result (typo)
2010-07-17 17:45 ` Liam Girdwood
@ 2010-07-17 18:47 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-07-17 18:47 UTC (permalink / raw)
To: Liam Girdwood
Cc: alsa-devel, Takashi Iwai, Kulikov Vasiliy, kernel-janitors,
linux-kernel, Peter Ujfalusi, Miguel Aguilar
On Sat, Jul 17, 2010 at 06:45:33PM +0100, Liam Girdwood wrote:
> On Fri, 2010-07-16 at 20:16 +0400, Kulikov Vasiliy wrote:
> > The code checks 'davinci_vc' after kzalloc() and do not checks
> > 'davinci_vcif_dev' that kzalloc() result is assigned to. It seems that
> > it is a typo (autocompletion?).
> > Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Applied, thanks. Kulikov could you please check the subject lines
you're using for your patches - try to be consistent with the rest of
the patches for the same code area.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-17 18:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-16 16:16 [PATCH 13/15] sound/soc: davinci: check kzalloc() result (typo) Kulikov Vasiliy
2010-07-17 17:45 ` Liam Girdwood
2010-07-17 18:47 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox