* [PATCH 05/19] arch/x86/kernel: use for_each_pci_dev()
@ 2010-07-03 16:03 Kulikov Vasiliy
2010-07-19 13:42 ` Roedel, Joerg
0 siblings, 1 reply; 2+ messages in thread
From: Kulikov Vasiliy @ 2010-07-03 16:03 UTC (permalink / raw)
To: Kernel Janitors
Cc: Joerg Roedel, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86,
iommu, linux-kernel
Use for_each_pci_dev() to simplify the code.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
arch/x86/kernel/amd_iommu.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
index 0d20286..29dd3b9 100644
--- a/arch/x86/kernel/amd_iommu.c
+++ b/arch/x86/kernel/amd_iommu.c
@@ -2609,8 +2609,7 @@ int __init amd_iommu_init_passthrough(void)
pt_domain->mode |= PAGE_MODE_NONE;
- while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
-
+ for_each_pci_dev(dev) {
if (!check_device(&dev->dev))
continue;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 05/19] arch/x86/kernel: use for_each_pci_dev()
2010-07-03 16:03 [PATCH 05/19] arch/x86/kernel: use for_each_pci_dev() Kulikov Vasiliy
@ 2010-07-19 13:42 ` Roedel, Joerg
0 siblings, 0 replies; 2+ messages in thread
From: Roedel, Joerg @ 2010-07-19 13:42 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: Kernel Janitors, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
x86@kernel.org, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
On Sat, Jul 03, 2010 at 12:03:51PM -0400, Kulikov Vasiliy wrote:
> Use for_each_pci_dev() to simplify the code.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
> arch/x86/kernel/amd_iommu.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
> index 0d20286..29dd3b9 100644
> --- a/arch/x86/kernel/amd_iommu.c
> +++ b/arch/x86/kernel/amd_iommu.c
> @@ -2609,8 +2609,7 @@ int __init amd_iommu_init_passthrough(void)
>
> pt_domain->mode |= PAGE_MODE_NONE;
>
> - while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
> -
> + for_each_pci_dev(dev) {
> if (!check_device(&dev->dev))
> continue;
Applied, thanks.
--
Joerg Roedel - AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-19 13:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-03 16:03 [PATCH 05/19] arch/x86/kernel: use for_each_pci_dev() Kulikov Vasiliy
2010-07-19 13:42 ` Roedel, Joerg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).