From: Andreas Gruenbacher <agruen@suse.de>
To: Wang Sheng-Hui <crosslonelyover@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Eric Sandeen <sandeen@redhat.com>,
linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
linux-mm@kvack.org, linux-ext4 <linux-ext4@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > 0
Date: Mon, 19 Jul 2010 18:39:06 +0000 [thread overview]
Message-ID: <201007192039.06670.agruen@suse.de> (raw)
In-Reply-To: <4C42A10B.2080904@gmail.com>
On Sunday 18 July 2010 08:36:59 Wang Sheng-Hui wrote:
> I regenerated the patch. Please check it.
The logic for calculating how many objects to free is still wrong:
mb_cache_shrink_fn returns the number of entries scaled by
sysctl_vfs_cache_pressure / 100. It should also scale nr_to_scan by the
inverse of that. The sysctl_vfs_cache_pressure = 0 case (never scale) may
require special attention.
See dcache_shrinker() in fs/dcache.c.
Thanks,
Andreas
next prev parent reply other threads:[~2010-07-19 18:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-18 1:01 [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > Wang Sheng-Hui
2010-07-18 4:06 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan Eric Sandeen
2010-07-18 6:01 ` Christoph Hellwig
2010-07-18 6:36 ` Wang Sheng-Hui
2010-07-19 18:39 ` Andreas Gruenbacher [this message]
2010-07-20 1:02 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > shenghui
2010-07-20 1:04 ` shenghui
2010-07-20 15:13 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan Eric Sandeen
2010-07-20 16:34 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > 0 Andreas Gruenbacher
2010-07-19 18:40 ` Andreas Gruenbacher
2010-07-21 10:53 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > Wang Sheng-Hui
2010-07-21 14:00 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan Eric Sandeen
2010-07-19 16:19 ` [PATCH 1/2] mbcache: Remove unused features Andreas Gruenbacher
2010-07-21 17:44 ` [PATCH 2/2] mbcache: fix shrinker function return value Andreas Gruenbacher
2010-07-21 17:57 ` [PATCH 0/2] mbcache fixes Andreas Gruenbacher
2010-07-21 23:22 ` Al Viro
2010-07-22 0:54 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan Wang Sheng-Hui
2010-07-22 1:06 ` [PATCH] fix return value for mb_cache_shrink_fn when nr_to_scan > shenghui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007192039.06670.agruen@suse.de \
--to=agruen@suse.de \
--cc=crosslonelyover@gmail.com \
--cc=hch@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sandeen@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).