From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Date: Tue, 20 Jul 2010 23:12:01 +0000 Subject: Re: [PATCH 6/8] xfs: fix unsigned underflow Message-Id: <20100720231201.GQ32635@dastard> List-Id: References: <1279219605-12631-1-git-send-email-segooon@gmail.com> <20100715212116.GA7013@infradead.org> <1279654533.1859.242.camel@doink> In-Reply-To: <1279654533.1859.242.camel@doink> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alex Elder Cc: Christoph Hellwig , kernel-janitors@vger.kernel.org, Kulikov Vasiliy , linux-kernel@vger.kernel.org, xfs@oss.sgi.com On Tue, Jul 20, 2010 at 02:35:33PM -0500, Alex Elder wrote: > On Thu, 2010-07-15 at 17:21 -0400, Christoph Hellwig wrote: > > On Thu, Jul 15, 2010 at 10:46:45PM +0400, Kulikov Vasiliy wrote: > > > map_len is unsigned. Checking map_len <= 0 is buggy when it should be > > > below zero. So, check exact expression instead of map_len. > > > > > > Signed-off-by: Kulikov Vasiliy > > > > Looks good, > > > > Reviewed-by: Christoph Hellwig > > > > Looks good to me too. Do you want me to pull this > in via the XFS tree, or do you have other plans? Already got it, Alex. Cheers, Dave. -- Dave Chinner david@fromorbit.com