From: David Miller <davem@davemloft.net>
To: buytenh@wantstofly.org
Cc: error27@gmail.com, joe@perches.com, jpirko@redhat.com,
kirjanov@gmail.com, saeed@marvell.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch -next v2] mv643xx_eth: potential null dereference
Date: Fri, 23 Jul 2010 20:05:55 +0000 [thread overview]
Message-ID: <20100723.130555.35023547.davem@davemloft.net> (raw)
In-Reply-To: <20100723111818.GV21121@mail.wantstofly.org>
From: Lennert Buytenhek <buytenh@wantstofly.org>
Date: Fri, 23 Jul 2010 13:18:18 +0200
> On Fri, Jul 23, 2010 at 01:05:05PM +0200, Dan Carpenter wrote:
>
>> We assume that "pd" can be null on the previous line, and throughout the
>> function so we should check it here as well. This was introduced by
>> 9b2c2ff7a1c0 "mv643xx_eth: use sw csum for big packets"
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Acked-by: Lennert Buytenhek <buytenh@wantstofly.org>
Applied.
next prev parent reply other threads:[~2010-07-23 20:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 10:15 [patch -next] mv643xx_eth: potential null dereference Dan Carpenter
2010-07-23 10:32 ` Joe Perches
2010-07-23 11:05 ` [patch -next v2] " Dan Carpenter
2010-07-23 11:18 ` Lennert Buytenhek
2010-07-23 20:05 ` David Miller [this message]
2010-07-23 16:30 ` walter harms
2010-07-23 22:15 ` Dan Carpenter
2010-07-24 8:59 ` walter harms
2010-07-24 19:00 ` Lennert Buytenhek
2010-07-25 14:47 ` walter harms
2010-07-25 15:54 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100723.130555.35023547.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=buytenh@wantstofly.org \
--cc=error27@gmail.com \
--cc=joe@perches.com \
--cc=jpirko@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kirjanov@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox