From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Ortiz Date: Sun, 25 Jul 2010 21:32:41 +0000 Subject: Re: [PATCH 2/8] touchscreen: fix sign bug Message-Id: <20100725213240.GA2613@sortiz-mobl> List-Id: References: <1279219435-12128-1-git-send-email-segooon@gmail.com> In-Reply-To: <1279219435-12128-1-git-send-email-segooon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kulikov Vasiliy Cc: kernel-janitors@vger.kernel.org, Dmitry Torokhov , Luotao Fu , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Hi Vasiliy, On Thu, Jul 15, 2010 at 10:43:54PM +0400, Kulikov Vasiliy wrote: > platform_get_irq_byname() can return negative results, it is not seen to > unsigned ts_irq. Make it signed. Patch applied to my mfd tree, thanks. Cheers, Samuel. > Signed-off-by: Kulikov Vasiliy > --- > drivers/input/touchscreen/stmpe-ts.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c > index 77f4374..656148e 100644 > --- a/drivers/input/touchscreen/stmpe-ts.c > +++ b/drivers/input/touchscreen/stmpe-ts.c > @@ -269,7 +269,7 @@ static int __devinit stmpe_input_probe(struct platform_device *pdev) > struct input_dev *idev; > struct stmpe_ts_platform_data *ts_pdata = NULL; > int ret = 0; > - unsigned int ts_irq; > + int ts_irq; > > ts_irq = platform_get_irq_byname(pdev, "FIFO_TH"); > if (ts_irq < 0) > -- > 1.7.0.4 > -- Intel Open Source Technology Centre http://oss.intel.com/