From: Dan Carpenter <error27@gmail.com>
To: Debora Velarde <debora@linux.vnet.ibm.com>
Cc: Rajiv Andrade <srajiv@linux.vnet.ibm.com>,
Marcel Selhorst <m.selhorst@sirrix.com>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [patch] tmp_atmel: request correct region
Date: Thu, 29 Jul 2010 08:50:14 +0000 [thread overview]
Message-ID: <20100729085014.GT26313@bicker> (raw)
We wanted to request "base". "tpm_atmel.base" is zero here. This bug
was introduced by e0dd03caf20d "[PATCH] tpm: return chip from
tpm_register_hardware".
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
Found with a static checker. I don't have the hardware to test this.
diff --git a/drivers/char/tpm/tpm_atmel.c b/drivers/char/tpm/tpm_atmel.c
index c64a1bc..090b3ec 100644
--- a/drivers/char/tpm/tpm_atmel.c
+++ b/drivers/char/tpm/tpm_atmel.c
@@ -205,7 +205,7 @@ static int __init init_atmel(void)
have_region (atmel_request_region
- (tpm_atmel.base, region_size, "tpm_atmel0") = NULL) ? 0 : 1;
+ (base, region_size, "tpm_atmel0") = NULL) ? 0 : 1;
pdev = platform_device_register_simple("tpm_atmel", -1, NULL, 0);
if (IS_ERR(pdev)) {
reply other threads:[~2010-07-29 8:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100729085014.GT26313@bicker \
--to=error27@gmail.com \
--cc=debora@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.selhorst@sirrix.com \
--cc=srajiv@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).