* [patch] tmp_atmel: request correct region
@ 2010-07-29 8:50 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2010-07-29 8:50 UTC (permalink / raw)
To: Debora Velarde
Cc: Rajiv Andrade, Marcel Selhorst, tpmdd-devel, linux-kernel,
kernel-janitors
We wanted to request "base". "tpm_atmel.base" is zero here. This bug
was introduced by e0dd03caf20d "[PATCH] tpm: return chip from
tpm_register_hardware".
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
Found with a static checker. I don't have the hardware to test this.
diff --git a/drivers/char/tpm/tpm_atmel.c b/drivers/char/tpm/tpm_atmel.c
index c64a1bc..090b3ec 100644
--- a/drivers/char/tpm/tpm_atmel.c
+++ b/drivers/char/tpm/tpm_atmel.c
@@ -205,7 +205,7 @@ static int __init init_atmel(void)
have_region (atmel_request_region
- (tpm_atmel.base, region_size, "tpm_atmel0") = NULL) ? 0 : 1;
+ (base, region_size, "tpm_atmel0") = NULL) ? 0 : 1;
pdev = platform_device_register_simple("tpm_atmel", -1, NULL, 0);
if (IS_ERR(pdev)) {
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-07-29 8:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-29 8:50 [patch] tmp_atmel: request correct region Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).