From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: smatch: module_init unwinding on errors
Date: Thu, 29 Jul 2010 20:18:03 +0000 [thread overview]
Message-ID: <20100729201803.GW26313@bicker> (raw)
In-Reply-To: <20100729174329.GU26313@bicker>
On Thu, Jul 29, 2010 at 11:00:07AM -0700, Randy Dunlap wrote:
> Hi Dan,
>
> Most drivers just use the result of request_region() as a pass/fail indicator.
> Only a very few of them actually save the result pointer; mostly they just pass
> bar to release_region().
>
That was another thing which was concerning me. request_region()
returns freshly allocated memory. Isn't it a leak to discard this?
regards,
dan carpenter
next prev parent reply other threads:[~2010-07-29 20:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 17:43 smatch: module_init unwinding on errors Dan Carpenter
2010-07-29 18:00 ` Randy Dunlap
2010-07-29 20:18 ` Dan Carpenter [this message]
2010-08-05 21:19 ` Randy Dunlap
2010-08-06 6:28 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100729201803.GW26313@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).