From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <error27@gmail.com>
Date: Thu, 29 Jul 2010 20:18:03 +0000
Subject: Re: smatch: module_init unwinding on errors
Message-Id: <20100729201803.GW26313@bicker>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20100729174329.GU26313@bicker>
In-Reply-To: <20100729174329.GU26313@bicker>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kernel-janitors@vger.kernel.org

On Thu, Jul 29, 2010 at 11:00:07AM -0700, Randy Dunlap wrote:
> Hi Dan,
> 
> Most drivers just use the result of request_region() as a pass/fail indicator.
> Only a very few of them actually save the result pointer;  mostly they just pass
> bar to release_region().
> 

That was another thing which was concerning me.  request_region()
returns freshly allocated memory.  Isn't it a leak to discard this?

regards,
dan carpenter