* Re: [PATCH 10/11] uio: do not use PCI resources before
2010-08-03 15:44 [PATCH 10/11] uio: do not use PCI resources before pci_enable_device() Kulikov Vasiliy
@ 2010-08-03 15:42 ` Michael S. Tsirkin
2010-08-03 17:20 ` Hans J. Koch
1 sibling, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2010-08-03 15:42 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: kernel-janitors, Hans J. Koch, Greg Kroah-Hartman, Jesse Barnes,
Tejun Heo, kvm, linux-kernel
On Tue, Aug 03, 2010 at 07:44:23PM +0400, Kulikov Vasiliy wrote:
> IRQ and resource[] may not have correct values until
> after PCI hotplug setup occurs at pci_enable_device() time.
>
> The semantic match that finds this problem is as follows:
>
> // <smpl>
> @@
> identifier x;
> identifier request ~= "pci_request.*|pci_resource.*";
> @@
>
> (
> * x->irq
> |
> * x->resource
> |
> * request(x, ...)
> )
> ...
> *pci_enable_device(x)
> // </smpl>
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Looks sane.
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/uio/uio_pci_generic.c | 13 +++++++------
> 1 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c
> index 85c9884..fc22e1e 100644
> --- a/drivers/uio/uio_pci_generic.c
> +++ b/drivers/uio/uio_pci_generic.c
> @@ -128,12 +128,6 @@ static int __devinit probe(struct pci_dev *pdev,
> struct uio_pci_generic_dev *gdev;
> int err;
>
> - if (!pdev->irq) {
> - dev_warn(&pdev->dev, "No IRQ assigned to device: "
> - "no support for interrupts?\n");
> - return -ENODEV;
> - }
> -
> err = pci_enable_device(pdev);
> if (err) {
> dev_err(&pdev->dev, "%s: pci_enable_device failed: %d\n",
> @@ -141,6 +135,13 @@ static int __devinit probe(struct pci_dev *pdev,
> return err;
> }
>
> + if (!pdev->irq) {
> + dev_warn(&pdev->dev, "No IRQ assigned to device: "
> + "no support for interrupts?\n");
> + pci_disable_device(pdev);
> + return -ENODEV;
> + }
> +
> err = verify_pci_2_3(pdev);
> if (err)
> goto err_verify;
> --
> 1.7.0.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 10/11] uio: do not use PCI resources before pci_enable_device()
2010-08-03 15:42 ` [PATCH 10/11] uio: do not use PCI resources before Michael S. Tsirkin
@ 2010-08-03 15:44 Kulikov Vasiliy
2010-08-03 15:42 ` [PATCH 10/11] uio: do not use PCI resources before Michael S. Tsirkin
2010-08-03 17:20 ` Hans J. Koch
-1 siblings, 2 replies; 3+ messages in thread
From: Kulikov Vasiliy @ 2010-08-03 15:44 UTC (permalink / raw)
To: kernel-janitors
Cc: Michael S. Tsirkin, Hans J. Koch, Greg Kroah-Hartman,
Jesse Barnes, Tejun Heo, kvm, linux-kernel
IRQ and resource[] may not have correct values until
after PCI hotplug setup occurs at pci_enable_device() time.
The semantic match that finds this problem is as follows:
// <smpl>
@@
identifier x;
identifier request ~= "pci_request.*|pci_resource.*";
@@
(
* x->irq
|
* x->resource
|
* request(x, ...)
)
...
*pci_enable_device(x)
// </smpl>
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
drivers/uio/uio_pci_generic.c | 13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c
index 85c9884..fc22e1e 100644
--- a/drivers/uio/uio_pci_generic.c
+++ b/drivers/uio/uio_pci_generic.c
@@ -128,12 +128,6 @@ static int __devinit probe(struct pci_dev *pdev,
struct uio_pci_generic_dev *gdev;
int err;
- if (!pdev->irq) {
- dev_warn(&pdev->dev, "No IRQ assigned to device: "
- "no support for interrupts?\n");
- return -ENODEV;
- }
-
err = pci_enable_device(pdev);
if (err) {
dev_err(&pdev->dev, "%s: pci_enable_device failed: %d\n",
@@ -141,6 +135,13 @@ static int __devinit probe(struct pci_dev *pdev,
return err;
}
+ if (!pdev->irq) {
+ dev_warn(&pdev->dev, "No IRQ assigned to device: "
+ "no support for interrupts?\n");
+ pci_disable_device(pdev);
+ return -ENODEV;
+ }
+
err = verify_pci_2_3(pdev);
if (err)
goto err_verify;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 10/11] uio: do not use PCI resources before
2010-08-03 15:44 [PATCH 10/11] uio: do not use PCI resources before pci_enable_device() Kulikov Vasiliy
2010-08-03 15:42 ` [PATCH 10/11] uio: do not use PCI resources before Michael S. Tsirkin
@ 2010-08-03 17:20 ` Hans J. Koch
1 sibling, 0 replies; 3+ messages in thread
From: Hans J. Koch @ 2010-08-03 17:20 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: kernel-janitors, Michael S. Tsirkin, Hans J. Koch,
Greg Kroah-Hartman, Jesse Barnes, Tejun Heo, kvm, linux-kernel
On Tue, Aug 03, 2010 at 07:44:23PM +0400, Kulikov Vasiliy wrote:
> IRQ and resource[] may not have correct values until
> after PCI hotplug setup occurs at pci_enable_device() time.
>
> The semantic match that finds this problem is as follows:
>
> // <smpl>
> @@
> identifier x;
> identifier request ~= "pci_request.*|pci_resource.*";
> @@
>
> (
> * x->irq
> |
> * x->resource
> |
> * request(x, ...)
> )
> ...
> *pci_enable_device(x)
> // </smpl>
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Looks alright to me, thanks!
Signed-off-by: Hans J. Koch <hjk@linutronix.de>
> ---
> drivers/uio/uio_pci_generic.c | 13 +++++++------
> 1 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c
> index 85c9884..fc22e1e 100644
> --- a/drivers/uio/uio_pci_generic.c
> +++ b/drivers/uio/uio_pci_generic.c
> @@ -128,12 +128,6 @@ static int __devinit probe(struct pci_dev *pdev,
> struct uio_pci_generic_dev *gdev;
> int err;
>
> - if (!pdev->irq) {
> - dev_warn(&pdev->dev, "No IRQ assigned to device: "
> - "no support for interrupts?\n");
> - return -ENODEV;
> - }
> -
> err = pci_enable_device(pdev);
> if (err) {
> dev_err(&pdev->dev, "%s: pci_enable_device failed: %d\n",
> @@ -141,6 +135,13 @@ static int __devinit probe(struct pci_dev *pdev,
> return err;
> }
>
> + if (!pdev->irq) {
> + dev_warn(&pdev->dev, "No IRQ assigned to device: "
> + "no support for interrupts?\n");
> + pci_disable_device(pdev);
> + return -ENODEV;
> + }
> +
> err = verify_pci_2_3(pdev);
> if (err)
> goto err_verify;
> --
> 1.7.0.4
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-03 17:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-03 15:44 [PATCH 10/11] uio: do not use PCI resources before pci_enable_device() Kulikov Vasiliy
2010-08-03 15:42 ` [PATCH 10/11] uio: do not use PCI resources before Michael S. Tsirkin
2010-08-03 17:20 ` Hans J. Koch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).