* [PATCH 9/42] drivers/scsi: Adjust confusing if indentation
@ 2010-08-05 20:19 Julia Lawall
2010-08-06 7:49 ` Dan Carpenter
2010-08-06 7:59 ` [PATCH] scsi: mpt2sas: Add space in printk Dan Carpenter
0 siblings, 2 replies; 6+ messages in thread
From: Julia Lawall @ 2010-08-05 20:19 UTC (permalink / raw)
To: James E.J. Bottomley, linux-scsi, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Outdent the code following the if.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@
(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
if (p1[0].column = p2[0].column):
cocci.print_main("branch",p1)
cocci.print_secs("after",p2)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
This might be the wrong fix, however it doesn't change the current semantics.
drivers/scsi/arcmsr/arcmsr_hba.c | 4 ++--
drivers/scsi/mpt2sas/mpt2sas_base.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
index 95a895d..c4e5cdc 100644
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -877,8 +877,8 @@ static void arcmsr_report_ccb_state(struct AdapterControlBlock *acb,
if (!error) {
if (acb->devstate[id][lun] = ARECA_RAID_GONE)
acb->devstate[id][lun] = ARECA_RAID_GOOD;
- ccb->pcmd->result = DID_OK << 16;
- arcmsr_ccb_complete(ccb);
+ ccb->pcmd->result = DID_OK << 16;
+ arcmsr_ccb_complete(ccb);
}else{
switch (ccb->arcmsr_cdb.DeviceStatus) {
case ARCMSR_DEV_SELECT_TIMEOUT: {
diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
index 57bcd5c..12faf64 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_base.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
@@ -534,7 +534,7 @@ _base_display_event_data(struct MPT2SAS_ADAPTER *ioc,
if (event_data->DiscoveryStatus)
printk("discovery_status(0x%08x)",
le32_to_cpu(event_data->DiscoveryStatus));
- printk("\n");
+ printk("\n");
return;
}
case MPI2_EVENT_SAS_BROADCAST_PRIMITIVE:
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 9/42] drivers/scsi: Adjust confusing if indentation
2010-08-05 20:19 [PATCH 9/42] drivers/scsi: Adjust confusing if indentation Julia Lawall
@ 2010-08-06 7:49 ` Dan Carpenter
2010-08-06 9:42 ` Nick Cheng
2010-08-06 7:59 ` [PATCH] scsi: mpt2sas: Add space in printk Dan Carpenter
1 sibling, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2010-08-06 7:49 UTC (permalink / raw)
To: Julia Lawall
Cc: James E.J. Bottomley, linux-scsi, linux-kernel, kernel-janitors,
nick.cheng
This should go to Nick Cheng. He would know about the arcmsr driver.
regards,
dan carpenter
On Thu, Aug 05, 2010 at 10:19:36PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Outdent the code following the if.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r disable braces4@
> position p1,p2;
> statement S1,S2;
> @@
>
> (
> if (...) { ... }
> |
> if (...) S1@p1 S2@p2
> )
>
> @script:python@
> p1 << r.p1;
> p2 << r.p2;
> @@
>
> if (p1[0].column = p2[0].column):
> cocci.print_main("branch",p1)
> cocci.print_secs("after",p2)
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> This might be the wrong fix, however it doesn't change the current semantics.
>
> drivers/scsi/arcmsr/arcmsr_hba.c | 4 ++--
> drivers/scsi/mpt2sas/mpt2sas_base.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
> index 95a895d..c4e5cdc 100644
> --- a/drivers/scsi/arcmsr/arcmsr_hba.c
> +++ b/drivers/scsi/arcmsr/arcmsr_hba.c
> @@ -877,8 +877,8 @@ static void arcmsr_report_ccb_state(struct AdapterControlBlock *acb,
> if (!error) {
> if (acb->devstate[id][lun] = ARECA_RAID_GONE)
> acb->devstate[id][lun] = ARECA_RAID_GOOD;
> - ccb->pcmd->result = DID_OK << 16;
> - arcmsr_ccb_complete(ccb);
> + ccb->pcmd->result = DID_OK << 16;
> + arcmsr_ccb_complete(ccb);
> }else{
> switch (ccb->arcmsr_cdb.DeviceStatus) {
> case ARCMSR_DEV_SELECT_TIMEOUT: {
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
> index 57bcd5c..12faf64 100644
> --- a/drivers/scsi/mpt2sas/mpt2sas_base.c
> +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
> @@ -534,7 +534,7 @@ _base_display_event_data(struct MPT2SAS_ADAPTER *ioc,
> if (event_data->DiscoveryStatus)
> printk("discovery_status(0x%08x)",
> le32_to_cpu(event_data->DiscoveryStatus));
> - printk("\n");
> + printk("\n");
> return;
> }
> case MPI2_EVENT_SAS_BROADCAST_PRIMITIVE:
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] scsi: mpt2sas: Add space in printk
2010-08-05 20:19 [PATCH 9/42] drivers/scsi: Adjust confusing if indentation Julia Lawall
2010-08-06 7:49 ` Dan Carpenter
@ 2010-08-06 7:59 ` Dan Carpenter
2010-08-09 14:28 ` Desai, Kashyap
1 sibling, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2010-08-06 7:59 UTC (permalink / raw)
To: Julia Lawall
Cc: James E.J. Bottomley, linux-scsi, linux-kernel, kernel-janitors,
eric.moore, kashyap.desai
Add a space in the output:
old: Discovery: (stop)discovery_status(0x%08x)
new: Discovery: (stop) discovery_status(0x%08x)
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
This goes on top of Julia's [PATCH 9/42] drivers/scsi: Adjust
confusing if indentation
diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
index 12faf64..562b909 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_base.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
@@ -532,7 +532,7 @@ _base_display_event_data(struct MPT2SAS_ADAPTER *ioc,
(event_data->ReasonCode = MPI2_EVENT_SAS_DISC_RC_STARTED) ?
"start" : "stop");
if (event_data->DiscoveryStatus)
- printk("discovery_status(0x%08x)",
+ printk(" discovery_status(0x%08x)",
le32_to_cpu(event_data->DiscoveryStatus));
printk("\n");
return;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH 9/42] drivers/scsi: Adjust confusing if indentation
2010-08-06 7:49 ` Dan Carpenter
@ 2010-08-06 9:42 ` Nick Cheng
0 siblings, 0 replies; 6+ messages in thread
From: Nick Cheng @ 2010-08-06 9:42 UTC (permalink / raw)
To: 'Dan Carpenter', 'Julia Lawall'
Cc: 'James E.J. Bottomley', linux-scsi, linux-kernel,
kernel-janitors
I agree.
Signed-off-by: Nick Cheng <nick.cheng@areca.com.tw>
-----Original Message-----
From: Dan Carpenter [mailto:error27@gmail.com]
Sent: Friday, August 06, 2010 3:50 PM
To: Julia Lawall
Cc: James E.J. Bottomley; linux-scsi@vger.kernel.org;
linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org;
nick.cheng@areca.com.tw
Subject: Re: [PATCH 9/42] drivers/scsi: Adjust confusing if indentation
This should go to Nick Cheng. He would know about the arcmsr driver.
regards,
dan carpenter
On Thu, Aug 05, 2010 at 10:19:36PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Outdent the code following the if.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r disable braces4@
> position p1,p2;
> statement S1,S2;
> @@
>
> (
> if (...) { ... }
> |
> if (...) S1@p1 S2@p2
> )
>
> @script:python@
> p1 << r.p1;
> p2 << r.p2;
> @@
>
> if (p1[0].column = p2[0].column):
> cocci.print_main("branch",p1)
> cocci.print_secs("after",p2)
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> This might be the wrong fix, however it doesn't change the current
semantics.
>
> drivers/scsi/arcmsr/arcmsr_hba.c | 4 ++--
> drivers/scsi/mpt2sas/mpt2sas_base.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c
b/drivers/scsi/arcmsr/arcmsr_hba.c
> index 95a895d..c4e5cdc 100644
> --- a/drivers/scsi/arcmsr/arcmsr_hba.c
> +++ b/drivers/scsi/arcmsr/arcmsr_hba.c
> @@ -877,8 +877,8 @@ static void arcmsr_report_ccb_state(struct
AdapterControlBlock *acb,
> if (!error) {
> if (acb->devstate[id][lun] = ARECA_RAID_GONE)
> acb->devstate[id][lun] = ARECA_RAID_GOOD;
> - ccb->pcmd->result = DID_OK << 16;
> - arcmsr_ccb_complete(ccb);
> + ccb->pcmd->result = DID_OK << 16;
> + arcmsr_ccb_complete(ccb);
> }else{
> switch (ccb->arcmsr_cdb.DeviceStatus) {
> case ARCMSR_DEV_SELECT_TIMEOUT: {
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c
b/drivers/scsi/mpt2sas/mpt2sas_base.c
> index 57bcd5c..12faf64 100644
> --- a/drivers/scsi/mpt2sas/mpt2sas_base.c
> +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
> @@ -534,7 +534,7 @@ _base_display_event_data(struct MPT2SAS_ADAPTER *ioc,
> if (event_data->DiscoveryStatus)
> printk("discovery_status(0x%08x)",
> le32_to_cpu(event_data->DiscoveryStatus));
> - printk("\n");
> + printk("\n");
> return;
> }
> case MPI2_EVENT_SAS_BROADCAST_PRIMITIVE:
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors"
in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] scsi: mpt2sas: Add space in printk
2010-08-06 7:59 ` [PATCH] scsi: mpt2sas: Add space in printk Dan Carpenter
@ 2010-08-09 14:28 ` Desai, Kashyap
2010-08-09 14:45 ` Julia Lawall
0 siblings, 1 reply; 6+ messages in thread
From: Desai, Kashyap @ 2010-08-09 14:28 UTC (permalink / raw)
To: Dan Carpenter, Julia Lawall
Cc: James E.J. Bottomley, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Moore, Eric
> -----Original Message-----
> From: Dan Carpenter [mailto:error27@gmail.com]
> Sent: Friday, August 06, 2010 1:29 PM
> To: Julia Lawall
> Cc: James E.J. Bottomley; linux-scsi@vger.kernel.org; linux-
> kernel@vger.kernel.org; kernel-janitors@vger.kernel.org; Moore, Eric;
> Desai, Kashyap
> Subject: [PATCH] scsi: mpt2sas: Add space in printk
>
> Add a space in the output:
> old: Discovery: (stop)discovery_status(0x%08x)
> new: Discovery: (stop) discovery_status(0x%08x)
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> This goes on top of Julia's [PATCH 9/42] drivers/scsi: Adjust
> confusing if indentation
>
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c
> b/drivers/scsi/mpt2sas/mpt2sas_base.c
> index 12faf64..562b909 100644
> --- a/drivers/scsi/mpt2sas/mpt2sas_base.c
> +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
> @@ -532,7 +532,7 @@ _base_display_event_data(struct MPT2SAS_ADAPTER
> *ioc,
> (event_data->ReasonCode =
> MPI2_EVENT_SAS_DISC_RC_STARTED) ?
> "start" : "stop");
> if (event_data->DiscoveryStatus)
> - printk("discovery_status(0x%08x)",
> + printk(" discovery_status(0x%08x)",
I don't see any significant reason for changing print. It not adding any benefit.
Thanks, Kashyap
> le32_to_cpu(event_data->DiscoveryStatus));
> printk("\n");
> return;
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] scsi: mpt2sas: Add space in printk
2010-08-09 14:28 ` Desai, Kashyap
@ 2010-08-09 14:45 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2010-08-09 14:45 UTC (permalink / raw)
To: Desai, Kashyap
Cc: Dan Carpenter, James E.J. Bottomley, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Moore, Eric
On Mon, 9 Aug 2010, Desai, Kashyap wrote:
>
>
> > -----Original Message-----
> > From: Dan Carpenter [mailto:error27@gmail.com]
> > Sent: Friday, August 06, 2010 1:29 PM
> > To: Julia Lawall
> > Cc: James E.J. Bottomley; linux-scsi@vger.kernel.org; linux-
> > kernel@vger.kernel.org; kernel-janitors@vger.kernel.org; Moore, Eric;
> > Desai, Kashyap
> > Subject: [PATCH] scsi: mpt2sas: Add space in printk
> >
> > Add a space in the output:
> > old: Discovery: (stop)discovery_status(0x%08x)
> > new: Discovery: (stop) discovery_status(0x%08x)
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
> > ---
> > This goes on top of Julia's [PATCH 9/42] drivers/scsi: Adjust
> > confusing if indentation
> >
> > diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c
> > b/drivers/scsi/mpt2sas/mpt2sas_base.c
> > index 12faf64..562b909 100644
> > --- a/drivers/scsi/mpt2sas/mpt2sas_base.c
> > +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
> > @@ -532,7 +532,7 @@ _base_display_event_data(struct MPT2SAS_ADAPTER
> > *ioc,
> > (event_data->ReasonCode =
> > MPI2_EVENT_SAS_DISC_RC_STARTED) ?
> > "start" : "stop");
> > if (event_data->DiscoveryStatus)
> > - printk("discovery_status(0x%08x)",
> > + printk(" discovery_status(0x%08x)",
> I don't see any significant reason for changing print. It not adding any benefit.
It would look a little nicer to have a space after the ) that is printed
by the previous statement.
julia
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-08-09 14:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-05 20:19 [PATCH 9/42] drivers/scsi: Adjust confusing if indentation Julia Lawall
2010-08-06 7:49 ` Dan Carpenter
2010-08-06 9:42 ` Nick Cheng
2010-08-06 7:59 ` [PATCH] scsi: mpt2sas: Add space in printk Dan Carpenter
2010-08-09 14:28 ` Desai, Kashyap
2010-08-09 14:45 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).