kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] rocket: add a mutex_unlock()
@ 2010-08-11 18:00 Dan Carpenter
  2010-08-17 11:25 ` Alan Cox
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-08-11 18:00 UTC (permalink / raw)
  To: kernel-janitors

This path needs a mutex_unlock().  This is stuff from the bkl to mutex
transition.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/char/rocket.c b/drivers/char/rocket.c
index 79c3bc6..7c79d24 100644
--- a/drivers/char/rocket.c
+++ b/drivers/char/rocket.c
@@ -1244,6 +1244,7 @@ static int set_config(struct tty_struct *tty, struct r_port *info,
 		}
 		info->flags = ((info->flags & ~ROCKET_USR_MASK) | (new_serial.flags & ROCKET_USR_MASK));
 		configure_r_port(tty, info, NULL);
+		mutex_unlock(&info->port.mutex);
 		return 0;
 	}
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [patch] rocket: add a mutex_unlock()
  2010-08-11 18:00 [patch] rocket: add a mutex_unlock() Dan Carpenter
@ 2010-08-17 11:25 ` Alan Cox
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2010-08-17 11:25 UTC (permalink / raw)
  To: kernel-janitors

On Wed, 11 Aug 2010 20:00:09 +0200
Dan Carpenter <error27@gmail.com> wrote:

> This path needs a mutex_unlock().  This is stuff from the bkl to mutex
> transition.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Ack to both - thanks for digging through and checking all this stuff

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-08-17 11:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-11 18:00 [patch] rocket: add a mutex_unlock() Dan Carpenter
2010-08-17 11:25 ` Alan Cox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).