Re: [patch] usb/uvc_v4l2: cleanup test for end of loop

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Dan,

Thanks for the patch.

On Thursday 12 August 2010 09:59:58 Dan Carpenter wrote:
> We're trying to test for the the end of the loop here.  "format" is
> never NULL.  We don't know what "format->fcc" is because we're past the
> end of the loop and I think "fmt->fmt.pix.pixelformat" comes from the
> user so we don't know what that is either.  It works, but it's cleaner
> to just test to see if (i = ARRAY_SIZE(uvc_formats).
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> diff --git a/drivers/usb/gadget/uvc_v4l2.c b/drivers/usb/gadget/uvc_v4l2.c
> index 2dcffda..5e807f0 100644
> --- a/drivers/usb/gadget/uvc_v4l2.c
> +++ b/drivers/usb/gadget/uvc_v4l2.c
> @@ -94,7 +94,7 @@ uvc_v4l2_set_format(struct uvc_video *video, struct
> v4l2_format *fmt) break;
>  	}
> 
> -	if (format = NULL || format->fcc != fmt->fmt.pix.pixelformat) {
> +	if (i = ARRAY_SIZE(uvc_formats)) {
>  		printk(KERN_INFO "Unsupported format 0x%08x.\n",
>  			fmt->fmt.pix.pixelformat);
>  		return -EINVAL;

-- 
Regards,

Laurent Pinchart