From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Tue, 07 Sep 2010 01:40:07 +0000 Subject: Re: [PATCH 5/8] drivers/atm/firestream.c: Fix unsigned return type Message-Id: <20100906.184007.58449609.davem@davemloft.net> List-Id: References: <1283713226-8429-1-git-send-email-julia@diku.dk> <1283713226-8429-6-git-send-email-julia@diku.dk> In-Reply-To: <1283713226-8429-6-git-send-email-julia@diku.dk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: julia@diku.dk Cc: chas@cmf.nrl.navy.mil, kernel-janitors@vger.kernel.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Julia Lawall Date: Sun, 5 Sep 2010 21:00:23 +0200 > The function has an unsigned return type, but returns a negative constant > to indicate an error condition. The result of calling the function is > always stored in a variable of type (signed) int, and thus unsigned can be > dropped from the return type. > > A sematic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) ... > Signed-off-by: Julia Lawall Applied.