From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Date: Wed, 08 Sep 2010 22:13:59 +0000 Subject: Re: [patch] pm_qos_params: cleanup: terminate a string Message-Id: <201009090014.00158.rjw@sisk.pl> List-Id: References: <20100903124105.GJ5437@bicker> <20100907062227.GB25651@gvim.org> <20100907133805.GA20050@gvim.org> In-Reply-To: <20100907133805.GA20050@gvim.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: markgross@thegnar.org Cc: Dan Carpenter , James Bottomley , Frederic Weisbecker , Jonathan Corbet , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Tuesday, September 07, 2010, mark gross wrote: > On Mon, Sep 06, 2010 at 11:22:27PM -0700, mark gross wrote: > > On Fri, Sep 03, 2010 at 02:41:06PM +0200, Dan Carpenter wrote: ... > > updated patch > > Signed-off-by: mark gross > > --mgross > > Subject: [PATCH] correct some pr_debug misuse and add a stronger parrameter check to > pm_qos_write for the ascii hex value case. Thanks to Dan Carpenter for > pointing out the problem! > > --- > kernel/pm_qos_params.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/kernel/pm_qos_params.c b/kernel/pm_qos_params.c > index f42d3f7..aae58d2 100644 > --- a/kernel/pm_qos_params.c > +++ b/kernel/pm_qos_params.c > @@ -155,7 +155,7 @@ static void update_target(int pm_qos_class) > call_notifier = 1; > atomic_set(&pm_qos_array[pm_qos_class]->target_value, > extreme_value); > - pr_debug(KERN_ERR "new target for qos %d is %d\n", pm_qos_class, > + pr_debug("new target for qos %d is %d\n", pm_qos_class, > atomic_read(&pm_qos_array[pm_qos_class]->target_value)); > } > spin_unlock_irqrestore(&pm_qos_lock, flags); The above doesn't apply to the Linus' tree any more. Care to fix? Rafael