From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasiliy Kulikov Date: Sat, 18 Sep 2010 11:21:50 +0000 Subject: Re: [PATCH] gpio: stmpe: fix error path Message-Id: <20100918112150.GA3351@albatros> List-Id: References: <1284317840-5131-1-git-send-email-segooon@gmail.com> <20100913193728.GA14993@pengutronix.de> In-Reply-To: <20100913193728.GA14993@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wolfram Sang Cc: kernel-janitors@vger.kernel.org, Rabin Vincent , Samuel Ortiz , Luotao Fu , Linus Walleij , linux-kernel@vger.kernel.org On Mon, Sep 13, 2010 at 21:37 +0200, Wolfram Sang wrote: > On Sun, Sep 12, 2010 at 10:57:19PM +0400, Vasiliy Kulikov wrote: > > Free allocated memory. Call stmpe_disable() if it was enabled. > > > > Signed-off-by: Vasiliy Kulikov > > --- > > Compile tested. > > Maybe It needs better error path. > > What do you mean here? Looks good to me so far. Forget it, I was wrong ;) -- Vasiliy