From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drivers/block/cciss.c (2.6.35.7): Fixed useless
Date: Tue, 21 Sep 2010 07:05:59 +0000 [thread overview]
Message-ID: <20100921070558.GA6234@bicker> (raw)
In-Reply-To: <115163.69814.qm@web45812.mail.sp1.yahoo.com>
Which version of gcc are you using? It doesn't print any error message
for me on version 4.3.2 (which is really old).
The idea is fine but the patch is all messed up. First of all the it's
reversed. It says '+' where it should say '-' and '-' where it should
say '+'.
Also your mail client has completely mangled it. It has removed spaces
from the start of lines and changed the tabs to spaces. Please read
Documentation/email-clients.txt and send an email to yourself. Save the
email as raw text. cat email.txt | patch -p1.
When that works resend it. Add these people to the CC list:
Mike Miller <mike.miller@hp.com>
Jens Axboe <jaxboe@fusionio.com>
"Stephen M. Cameron" <scameron@beardog.cce.hp.com>
iss_storagedev@hp.com
Also you don't need to copy all 16 lines of error messages. Just a
couple will do. But do say which version of gcc you are using.
regards,
dan carpenter
next prev parent reply other threads:[~2010-09-21 7:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 17:48 [PATCH] drivers/block/cciss.c (2.6.35.7): Fixed useless compile warning Poyo VL
2010-09-21 7:05 ` Dan Carpenter [this message]
2010-09-21 7:23 ` [PATCH] drivers/block/cciss.c (2.6.35.7): Fixed useless compile walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100921070558.GA6234@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox