From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: Fw: [PATCH] drivers/block/cciss.c (2.6.34.7): Fixed useless
Date: Tue, 21 Sep 2010 10:31:28 +0000 [thread overview]
Message-ID: <20100921102633.GA5989@bicker> (raw)
In-Reply-To: <481583.87768.qm@web45807.mail.sp1.yahoo.com>
On Tue, Sep 21, 2010 at 02:48:12AM -0700, Poyo VL wrote:
> GCC version: gcc version 4.5.0 20100604 [gcc-4_5-branch revision 160292] (SUSE
> Linux)
>
> And I'm sorry, the kernel version is 2.6.34.7 not 2.6.35.7.
It also applies to the 2.6.36-rc4 kernel with offset 45 so that's ok.
> But I selected almost all options from "make menuconfig", I think this is
> important to mention.
You can leave this information out.
> All warnings are like this one
> drivers/block/cciss.c: In function ‘dev_show_unique_id’:
> drivers/block/cciss.c:564:7: warning: ‘sn[0]’ may be used uninitialized in this
> function
> I tried to explain. The sn[] array is initialized here: else memcpy(sn,
> drv->serial_no, sizeof(sn)); so it is initialized in a conditional expression,
> and is is used downer. So, the compiler think that it can be used unititialized
> and it throws that warning.
> I fixed the patch, I am sorry, I'm a newbie.
Don't appologize. Kernel-janitors is here to help newbies.
This version was much better, but your email client is still changing
all the spaces to tabs. Can you send it again as version 3? Please
send the email to yourself and verify that the patch applies. Just save
the email as "raw format with headers" or whatever it's called. Then
`cat raw_email.txt | patch -p1` and send it to us again once that works.
regards,
dan carpenter
next prev parent reply other threads:[~2010-09-21 10:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 9:48 Fw: [PATCH] drivers/block/cciss.c (2.6.34.7): Fixed useless compile warning Poyo VL
2010-09-21 10:31 ` Dan Carpenter [this message]
2010-09-21 15:55 ` [PATCH] drivers/block/cciss.c (2.6.34.7): Fixed useless compile Miller, Mike (OS Dev)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100921102633.GA5989@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox