Re: [PATCH 1/4] x86: remove cast from void*

H. Peter Anvin
2010-09-14T18:20:49Z

On 09/14/2010 10:49 AM, Jeremy Fitzhardinge wrote:
> On 09/13/2010 10:18 PM, matt mooney wrote:
>> Unnecessary cast from void* in assignment.
>
> Not very keen on this. The cast may not be strictly required, but it
> does document what's going on there.
>

But unnecessary casts are problematic in that if the type changes, they
can hide a real bug in the future.

-hpa