Re: [PATCH 1/4] x86: remove cast from void*

matt mooney
2010-09-21T19:15:13Z

On 11:39 Tue 21 Sep , Jeremy Fitzhardinge wrote:
> On 09/13/2010 10:18 PM, matt mooney wrote:
> > Unnecessary cast from void* in assignment.
> >
> > Signed-off-by: matt mooney <mfm@muteddisk.com>
> > ---
> > arch/x86/xen/mmu.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> > index 42086ac..7436283 100644
> > --- a/arch/x86/xen/mmu.c
> > +++ b/arch/x86/xen/mmu.c
> > @@ -737,7 +737,7 @@ pgd_t *xen_get_user_pgd(pgd_t *pgd)
> >
> > if (offset < pgd_index(USER_LIMIT)) {
> > struct page *page = virt_to_page(pgd_page);
> > - user_ptr = (pgd_t *)page->private;
> > + user_ptr = page->private;
>
> Um, page->private is unsigned long anyway, so this is needed either way.
>

You're right. I missed that one, sorry; I really thought I had verified it.

-mfm