From: Jean Delvare <khali@linux-fr.org>
To: matt mooney <mfm-Oo0r1OC9pj9iLUuM0BA3LQ@public.gmane.org>
Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Ben Dooks (embedded platforms)"
<ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 05/24] i2c: change to new flag variable
Date: Sat, 25 Sep 2010 11:26:11 +0000 [thread overview]
Message-ID: <20100925132611.03ef0882@endymion.delvare> (raw)
In-Reply-To: <b3e2061e1e6703f7b84c0484030e07de6000546a.1285355033.git.mfm-Oo0r1OC9pj9iLUuM0BA3LQ@public.gmane.org>
On Fri, 24 Sep 2010 12:17:15 -0700, matt mooney wrote:
> Replace EXTRA_CFLAGS with ccflags-y.
>
> Signed-off-by: matt mooney <mfm@muteddisk.com>
> ---
> drivers/i2c/Makefile | 4 +---
> drivers/i2c/algos/Makefile | 4 +---
> drivers/i2c/busses/Makefile | 4 +---
> drivers/i2c/muxes/Makefile | 4 +---
> 4 files changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile
> index c00fd66..23ac61e 100644
> --- a/drivers/i2c/Makefile
> +++ b/drivers/i2c/Makefile
> @@ -9,6 +9,4 @@ obj-$(CONFIG_I2C_CHARDEV) += i2c-dev.o
> obj-$(CONFIG_I2C_MUX) += i2c-mux.o
> obj-y += algos/ busses/ muxes/
>
> -ifeq ($(CONFIG_I2C_DEBUG_CORE),y)
> -EXTRA_CFLAGS += -DDEBUG
> -endif
> +ccflags-$(CONFIG_I2C_DEBUG_CORE) := -DDEBUG
> diff --git a/drivers/i2c/algos/Makefile b/drivers/i2c/algos/Makefile
> index 18b3e96..215303f 100644
> --- a/drivers/i2c/algos/Makefile
> +++ b/drivers/i2c/algos/Makefile
> @@ -6,6 +6,4 @@ obj-$(CONFIG_I2C_ALGOBIT) += i2c-algo-bit.o
> obj-$(CONFIG_I2C_ALGOPCF) += i2c-algo-pcf.o
> obj-$(CONFIG_I2C_ALGOPCA) += i2c-algo-pca.o
>
> -ifeq ($(CONFIG_I2C_DEBUG_ALGO),y)
> -EXTRA_CFLAGS += -DDEBUG
> -endif
> +ccflags-$(CONFIG_I2C_DEBUG_ALGO) := -DDEBUG
> diff --git a/drivers/i2c/busses/Makefile b/drivers/i2c/busses/Makefile
> index c3ef492..033ad41 100644
> --- a/drivers/i2c/busses/Makefile
> +++ b/drivers/i2c/busses/Makefile
> @@ -76,6 +76,4 @@ obj-$(CONFIG_I2C_STUB) += i2c-stub.o
> obj-$(CONFIG_SCx200_ACB) += scx200_acb.o
> obj-$(CONFIG_SCx200_I2C) += scx200_i2c.o
>
> -ifeq ($(CONFIG_I2C_DEBUG_BUS),y)
> -EXTRA_CFLAGS += -DDEBUG
> -endif
> +ccflags-$(CONFIG_I2C_DEBUG_BUS) := -DDEBUG
> diff --git a/drivers/i2c/muxes/Makefile b/drivers/i2c/muxes/Makefile
> index bd83b52..6f49786 100644
> --- a/drivers/i2c/muxes/Makefile
> +++ b/drivers/i2c/muxes/Makefile
> @@ -3,6 +3,4 @@
>
> obj-$(CONFIG_I2C_MUX_PCA954x) += pca954x.o
>
> -ifeq ($(CONFIG_I2C_DEBUG_BUS),y)
> -EXTRA_CFLAGS += -DDEBUG
> -endif
> +ccflags-$(CONFIG_I2C_DEBUG_BUS) := -DDEBUG
If this is the way the whole kernel is going, I have no objection.
--
Jean Delvare
next prev parent reply other threads:[~2010-09-25 11:26 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 19:17 [PATCH 01/24] base: change to new flag variable matt mooney
2010-09-24 19:17 ` [PATCH 02/24] char: " matt mooney
2010-09-24 19:17 ` [PATCH 03/24] dma: " matt mooney
2010-09-24 19:17 ` [PATCH 04/24] hwmon: " matt mooney
2010-09-24 19:17 ` [PATCH 05/24] i2c: " matt mooney
2010-09-24 19:17 ` [PATCH 06/24] ide: " matt mooney
2010-09-24 19:17 ` [PATCH 07/24] ieee802154: " matt mooney
2010-09-24 19:17 ` [PATCH 08/24] infiniband: " matt mooney
2010-09-24 19:17 ` [PATCH 09/24] input: " matt mooney
2010-09-24 19:17 ` [PATCH 10/24] isdn: " matt mooney
2010-09-24 19:17 ` [PATCH 11/24] memstick: " matt mooney
2010-09-24 19:17 ` [PATCH 12/24] message: " matt mooney
2010-09-24 19:17 ` [PATCH 13/24] misc: " matt mooney
2010-09-24 19:17 ` [PATCH 14/24] mmc: " matt mooney
2010-09-24 19:17 ` [PATCH 15/24] net: " matt mooney
2010-09-24 19:17 ` [PATCH 16/24] pci: " matt mooney
2010-09-24 19:17 ` [PATCH 17/24] power: " matt mooney
2010-09-24 19:17 ` [PATCH 18/24] pps: " matt mooney
2010-09-24 19:17 ` [PATCH 19/24] rapidio: " matt mooney
2010-09-24 19:17 ` [PATCH 20/24] rtc: " matt mooney
2010-09-24 19:17 ` [PATCH 21/24] scsi: " matt mooney
2010-09-24 19:17 ` [PATCH 22/24] spi: " matt mooney
2010-09-24 19:17 ` [PATCH 23/24] usb: " matt mooney
2010-09-24 19:17 ` [PATCH 24/24] video: " matt mooney
2010-09-24 20:02 ` [usb-storage] [PATCH 23/24] usb: " Matthew Dharm
2010-09-24 20:28 ` matt mooney
2010-09-24 23:21 ` matt mooney
2010-10-08 18:33 ` [PATCH 22/24] spi: " Grant Likely
2010-09-25 1:37 ` [rtc-linux] [PATCH 20/24] rtc: " Wan ZongShun
2010-10-15 19:54 ` [PATCH 16/24] pci: " Jesse Barnes
2010-09-24 19:25 ` [PATCH 15/24] net: " John W. Linville
2010-09-24 20:01 ` David Miller
2010-09-28 13:02 ` [PATCH 13/24] misc: " Michał Mirosław
2010-09-29 22:55 ` matt mooney
2010-09-24 20:01 ` [PATCH 10/24] isdn: " David Miller
2010-09-26 10:31 ` [PATCH 07/24] ieee802154: " Dmitry Eremin-Solenikov
2010-09-24 20:01 ` [PATCH 06/24] ide: " David Miller
[not found] ` <b3e2061e1e6703f7b84c0484030e07de6000546a.1285355033.git.mfm-Oo0r1OC9pj9iLUuM0BA3LQ@public.gmane.org>
2010-09-25 11:26 ` Jean Delvare [this message]
[not found] ` <20100925132611.03ef0882-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-09-26 2:12 ` [PATCH 05/24] i2c: " matt mooney
[not found] ` <20100926021217.GC8191-HC+Z4NTRIlA6jSvU4L2mP2ItS4zQEDct@public.gmane.org>
2010-09-26 7:29 ` Jean Delvare
[not found] ` <20100926092931.68980448-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-09-26 18:07 ` matt mooney
2010-09-29 13:56 ` Jean Delvare
2010-09-24 23:54 ` [lm-sensors] [PATCH 04/24] hwmon: " Guenter Roeck
2010-09-27 15:04 ` Valdis.Kletnieks
2010-09-27 17:23 ` matt mooney
2010-09-25 2:52 ` [PATCH 01/24] base: " Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100925132611.03ef0882@endymion.delvare \
--to=khali@linux-fr.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mfm-Oo0r1OC9pj9iLUuM0BA3LQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox