Re: [PATCH 4/4] drivers/atm/idt77252.c: Remove unnecessary error

David Miller
2010-10-04T05:06:25Z

From: Julia Lawall <julia@diku.dk>
Date: Sat, 2 Oct 2010 16:37:07 +0200 (CEST)

> This code does not call deinit_card(card); in an error case, as done in
> other error-handling code in the same function. But actually, the called
> function init_sram can only return 0, so there is no need for the error
> check at all.
>
> init_sram is also given a void return type, and its single return statement
> at the end of the function is dropped.
>
> A simplified version of the sematic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
...
> Signed-off-by: Julia Lawall <julia@diku.dk>

Applied, thank you.