From: Sam Ravnborg <sam@ravnborg.org>
To: walter harms <wharms@bfs.de>
Cc: Tracey Dent <tdent48227@gmail.com>,
greg@kroah.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up
Date: Sun, 03 Oct 2010 20:51:28 +0000 [thread overview]
Message-ID: <20101003205128.GA16185@merkur.ravnborg.org> (raw)
In-Reply-To: <4CA879A1.3070400@bfs.de>
On Sun, Oct 03, 2010 at 02:40:01PM +0200, walter harms wrote:
>
>
> Tracey Dent schrieb:
> > Changed to use the proper ccflags-y option
> >
> > Signed-off-by: Tracey Dent <tdent48227@gmail.com>
> > ---
> > drivers/staging/cx25821/Makefile | 8 ++++----
> > 1 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/cx25821/Makefile b/drivers/staging/cx25821/Makefile
> > index d0eb16e..6448364 100644
> > --- a/drivers/staging/cx25821/Makefile
> > +++ b/drivers/staging/cx25821/Makefile
> > @@ -7,7 +7,7 @@ cx25821-objs := cx25821-core.o cx25821-cards.o cx25821-i2c.o \
> > obj-$(CONFIG_VIDEO_CX25821) += cx25821.o
> > obj-$(CONFIG_VIDEO_CX25821_ALSA) += cx25821-alsa.o
> >
> > -EXTRA_CFLAGS += -Idrivers/media/video
> > -EXTRA_CFLAGS += -Idrivers/media/common/tuners
> > -EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
> > -EXTRA_CFLAGS += -Idrivers/media/dvb/frontends
> > +ccflags-y := -Idrivers/media/video
> > +ccflags-y += -Idrivers/media/common/tuners
> > +ccflags-y += -Idrivers/media/dvb/dvb-core
> > +ccflags-y += -Idrivers/media/dvb/frontends
>
> they have invented vpath for this, did they ?
> note: I am not familiar with the linux makefile.
vpath is not the answer here.
Note that Tracy dent did the simple replacement of EXTRA_CFLAGS with ccflags-y.
The Makefiles could in many cases benefit from general cleanups - which many
of your futher comments is a good indicator of.
Sam
next prev parent reply other threads:[~2010-10-03 20:51 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-02 16:37 [PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up Makefile cflag lines Tracey Dent
2010-10-02 16:37 ` [PATCH v3 02/20] Staging: cxt1e1: " Tracey Dent
2010-10-02 16:37 ` [PATCH v3 03/20] Staging: dream: " Tracey Dent
2010-10-02 16:37 ` [PATCH v3 04/20] Staging: dream: camera: " Tracey Dent
2010-10-02 16:37 ` [PATCH v3 05/20] Staging: dream: qdsp5: " Tracey Dent
2010-10-02 16:37 ` [PATCH v3 06/20] Stagng: easycap: " Tracey Dent
2010-10-02 16:37 ` [PATCH v3 07/20] Staging: rt2860: " Tracey Dent
2010-10-02 16:37 ` [PATCH v3 08/20] Staging: rt2870: " Tracey Dent
2010-10-02 16:37 ` [PATCH v3 09/20] Staging: rtl8187se: " Tracey Dent
2010-10-03 12:47 ` [PATCH v3 09/20] Staging: rtl8187se: Makefile: cleaned up Makefile walter harms
2010-10-02 16:37 ` [PATCH v3 10/20] Staging: rtl8192e: Makefile: cleaned up Makefile cflag lines Tracey Dent
2010-10-02 16:38 ` [PATCH v3 11/20] Staging: rtl8192su: " Tracey Dent
2010-10-03 12:42 ` [PATCH v3 11/20] Staging: rtl8192su: Makefile: cleaned up Makefile walter harms
2010-10-03 13:39 ` [PATCH v3 11/20] Staging: rtl8192su: Makefile: cleaned up T Dent
2010-10-05 19:02 ` Greg KH
2010-10-02 16:38 ` [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned up Makefile cflag lines Tracey Dent
2010-10-03 12:48 ` [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned walter harms
2010-10-05 19:02 ` [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: Greg KH
2010-10-05 21:47 ` [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: cleaned T Dent
2010-10-05 21:51 ` T Dent
2010-10-05 22:20 ` [PATCH v3 12/20] Staging: rtl8192su: ieee80211: Makefile: Greg KH
2010-10-02 16:38 ` [PATCH v3 13/20] Staging: rtl8192u: Makefile: cleaned up Makefile cflag lines Tracey Dent
2010-10-03 12:50 ` [PATCH v3 13/20] Staging: rtl8192u: Makefile: cleaned up Makefile walter harms
2010-10-02 16:38 ` [PATCH v3 14/20] Staging: rtl8192u: ieee80211: Makefile: cleaned up Makefile cflag lines Tracey Dent
2010-10-03 13:06 ` [PATCH v3 14/20] Staging: rtl8192u: ieee80211: Makefile: cleaned walter harms
2010-10-02 16:38 ` [PATCH v3 15/20] Staging: tm6000: Makefile: cleaned up Makefile cflag lines Tracey Dent
2010-10-02 16:38 ` [PATCH v3 16/20] Staging: usbip: " Tracey Dent
2010-10-02 16:38 ` [PATCH v3 17/20] Staging: vt6655: " Tracey Dent
2010-10-02 16:38 ` [PATCH v3 18/20] Staging: vt6656: " Tracey Dent
2010-10-03 13:09 ` [PATCH v3 18/20] Staging: vt6656: Makefile: cleaned up Makefile walter harms
2010-10-02 16:38 ` [PATCH v3 19/20] Staging: wlags49_h2: Makefile: cleaned up Makefile cflag lines Tracey Dent
2010-10-02 16:38 ` [PATCH v3 20/20] Staging: wlags49_h25: " Tracey Dent
2010-10-03 12:40 ` [PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up Makefile walter harms
2010-10-03 20:51 ` Sam Ravnborg [this message]
2010-10-05 5:35 ` [PATCH v3 01/20] Staging: cx25821: Makefile: cleaned up matt mooney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101003205128.GA16185@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tdent48227@gmail.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox