From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Ian Lartey <ian@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: wm8804: fix error handling code
Date: Mon, 11 Oct 2010 12:36:09 +0000 [thread overview]
Message-ID: <20101011123609.GL9231@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20101011121555.GA32652@albatros>
On Mon, Oct 11, 2010 at 04:15:55PM +0400, Vasiliy Kulikov wrote:
> On Mon, Oct 11, 2010 at 13:00 +0100, Mark Brown wrote:
> > ...it's not clear to me that this change is an improvement - it'll make
> > the driver more fragile in the face of errors, I don't see a benefit in
> > refusing to register the variant for one bus if the other fails?
> I tried to implement your variant with depca driver in past, but it was
> rejected by David Miller:
> http://lists.openwall.net/netdev/2010/07/12/9
I disagree with David here, and in any case if you're going to make a
style change like this they really ought to be applied over all drivers
rather than just a few individual ones.
next prev parent reply other threads:[~2010-10-11 12:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-10 17:29 [PATCH] ASoC: wm8804: fix error handling code Vasiliy Kulikov
2010-10-11 12:00 ` Mark Brown
2010-10-11 12:15 ` Vasiliy Kulikov
2010-10-11 12:36 ` Mark Brown [this message]
2010-10-11 12:50 ` Vasiliy Kulikov
2010-10-11 12:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101011123609.GL9231@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=ian@opensource.wolfsonmicro.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=segooon@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox