* [PATCH] sh: boards/mach-x3proto: gpio: fix error handling code
@ 2010-10-10 17:28 Vasiliy Kulikov
2010-10-11 15:33 ` Paul Mundt
0 siblings, 1 reply; 2+ messages in thread
From: Vasiliy Kulikov @ 2010-10-10 17:28 UTC (permalink / raw)
To: kernel-janitors; +Cc: Paul Mundt, linux-sh, linux-kernel
Checks for (irq < 0) and (ilsel < 0) didn't make sense since they were
unsigned. Made them signed.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
I cannot compile this driver, so it is not tested.
arch/sh/boards/mach-x3proto/gpio.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/sh/boards/mach-x3proto/gpio.c b/arch/sh/boards/mach-x3proto/gpio.c
index 9fcd7ce..594adf7 100644
--- a/arch/sh/boards/mach-x3proto/gpio.c
+++ b/arch/sh/boards/mach-x3proto/gpio.c
@@ -79,7 +79,7 @@ struct gpio_chip x3proto_gpio_chip = {
int __init x3proto_gpio_setup(void)
{
- unsigned int ilsel;
+ int ilsel;
int ret, i;
ilsel = ilsel_enable(ILSEL_KEY);
@@ -92,7 +92,7 @@ int __init x3proto_gpio_setup(void)
for (i = 0; i < NR_BASEBOARD_GPIOS; i++) {
unsigned long flags;
- unsigned int irq = create_irq();
+ int irq = create_irq();
if (unlikely(irq < 0)) {
ret = -EINVAL;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sh: boards/mach-x3proto: gpio: fix error handling code
2010-10-10 17:28 [PATCH] sh: boards/mach-x3proto: gpio: fix error handling code Vasiliy Kulikov
@ 2010-10-11 15:33 ` Paul Mundt
0 siblings, 0 replies; 2+ messages in thread
From: Paul Mundt @ 2010-10-11 15:33 UTC (permalink / raw)
To: Vasiliy Kulikov; +Cc: kernel-janitors, linux-sh, linux-kernel
On Sun, Oct 10, 2010 at 09:28:27PM +0400, Vasiliy Kulikov wrote:
> Checks for (irq < 0) and (ilsel < 0) didn't make sense since they were
> unsigned. Made them signed.
>
> Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-11 15:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-10 17:28 [PATCH] sh: boards/mach-x3proto: gpio: fix error handling code Vasiliy Kulikov
2010-10-11 15:33 ` Paul Mundt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).