public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [patch 1/2] Staging: ft1000-usb: use the correct list head
Date: Fri, 15 Oct 2010 03:40:42 +0000	[thread overview]
Message-ID: <20101015034042.GF6614@bicker> (raw)

Using pdpram_blk here would cause an oops.  We intended to use
&freercvpool.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
index d0637c3..076ba75 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
@@ -1115,7 +1115,7 @@ u16 init_ft1000_netdev(struct ft1000_device *ft1000dev)
 
 
 err_free:
-	list_for_each_safe(cur, tmp, &pdpram_blk->list) {
+	list_for_each_safe(cur, tmp, &freercvpool) {
 		pdpram_blk = list_entry(cur, DPRAM_BLK, list);
 		list_del(&pdpram_blk->list);
 		kfree(pdpram_blk->pbuffer);

             reply	other threads:[~2010-10-15  3:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-15  3:40 Dan Carpenter [this message]
2010-10-15  6:19 ` [patch 1/2] Staging: ft1000-usb: use the correct list head Belisko Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101015034042.GF6614@bicker \
    --to=error27@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox