* [patch 1/2] Staging: ft1000-usb: use the correct list head
@ 2010-10-15 3:40 Dan Carpenter
2010-10-15 6:19 ` Belisko Marek
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-10-15 3:40 UTC (permalink / raw)
To: kernel-janitors
Using pdpram_blk here would cause an oops. We intended to use
&freercvpool.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
index d0637c3..076ba75 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
@@ -1115,7 +1115,7 @@ u16 init_ft1000_netdev(struct ft1000_device *ft1000dev)
err_free:
- list_for_each_safe(cur, tmp, &pdpram_blk->list) {
+ list_for_each_safe(cur, tmp, &freercvpool) {
pdpram_blk = list_entry(cur, DPRAM_BLK, list);
list_del(&pdpram_blk->list);
kfree(pdpram_blk->pbuffer);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch 1/2] Staging: ft1000-usb: use the correct list head
2010-10-15 3:40 [patch 1/2] Staging: ft1000-usb: use the correct list head Dan Carpenter
@ 2010-10-15 6:19 ` Belisko Marek
0 siblings, 0 replies; 2+ messages in thread
From: Belisko Marek @ 2010-10-15 6:19 UTC (permalink / raw)
To: kernel-janitors
On Fri, Oct 15, 2010 at 5:40 AM, Dan Carpenter <error27@gmail.com> wrote:
> Using pdpram_blk here would cause an oops. We intended to use
> &freercvpool.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
> index d0637c3..076ba75 100644
> --- a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
> +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
> @@ -1115,7 +1115,7 @@ u16 init_ft1000_netdev(struct ft1000_device *ft1000dev)
>
>
> err_free:
> - list_for_each_safe(cur, tmp, &pdpram_blk->list) {
> + list_for_each_safe(cur, tmp, &freercvpool) {
> pdpram_blk = list_entry(cur, DPRAM_BLK, list);
> list_del(&pdpram_blk->list);
> kfree(pdpram_blk->pbuffer);
>
Greg, you can add my Tested by: Marek Belisko <marek.belisko@gmail.com>
@Dan, good catch. Thanks.
Marek
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-15 6:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-15 3:40 [patch 1/2] Staging: ft1000-usb: use the correct list head Dan Carpenter
2010-10-15 6:19 ` Belisko Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox