* [patch 2/2] Staging: intel_sst: cleanup naming a little
@ 2010-10-15 3:44 Dan Carpenter
2010-10-15 4:36 ` Koul, Vinod
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-10-15 3:44 UTC (permalink / raw)
To: kernel-janitors
&sst_drv_ctx->streams[str_id].lock and &stream->lock are the same.
The mutex_lock() uses &stream->lock so this makes things consistent and
it's nicer to read as well.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/staging/intel_sst/intel_sst_app_interface.c b/drivers/staging/intel_sst/intel_sst_app_interface.c
index baf0ddc..086999b 100644
--- a/drivers/staging/intel_sst/intel_sst_app_interface.c
+++ b/drivers/staging/intel_sst/intel_sst_app_interface.c
@@ -1060,20 +1062,18 @@ long intel_sst_ioctl(struct file *file_ptr, unsigned int cmd, unsigned long arg)
retval = sst_capture_frame(str_id);
else {
retval = -EINVAL;
- mutex_unlock(
- &sst_drv_ctx->streams[str_id].lock);
+ mutex_unlock(&stream->lock);
break;
}
if (retval < 0) {
stream->status = STREAM_INIT;
- mutex_unlock(
- &sst_drv_ctx->streams[str_id].lock);
+ mutex_unlock(&stream->lock);
break;
}
} else {
retval = -EINVAL;
}
- mutex_unlock(&sst_drv_ctx->streams[str_id].lock);
+ mutex_unlock(&stream->lock);
break;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-15 4:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-15 3:44 [patch 2/2] Staging: intel_sst: cleanup naming a little Dan Carpenter
2010-10-15 4:36 ` Koul, Vinod
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox