From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Date: Mon, 18 Oct 2010 08:53:49 +0000
Subject: Re: [patch] ns83820: spin_lock_irq() => spin_lock()
Message-Id: <20101018.015349.226761791.davem@davemloft.net>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20101013191852.GD6060@bicker>
In-Reply-To: <20101013191852.GD6060@bicker>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: error27@gmail.com
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, mingo@elte.hu

From: Dan Carpenter <error27@gmail.com>
Date: Wed, 13 Oct 2010 21:18:53 +0200

> This is essentially cosmetic.  At this point the IRQs are already
> disabled because we called spin_lock_irq(&dev->rx_info.lock).
> 
> The real bug here was fixed back in 2006 in 3a10ccebe: "[PATCH] lock
> validator: fix ns83820.c irq-flags bug".  Prior to that patch, it was
> a "spin_lock_irq is not nestable" type bug.  The 2006 patch changes the
> unlock to not re-enable IRQs, which eliminates the potential deadlock.
> 
> But this bit was missed.  We should change the lock function as well so
> it balances nicely.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Applied.