From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 21 Oct 2010 19:24:24 +0000 Subject: [patch 3/3] V4L/DVB: s5p-fimc: dubious one-bit signed bitfields Message-Id: <20101021192424.GL5985@bicker> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mauro Carvalho Chehab Cc: Kyungmin Park , Sylwester Nawrocki , Pawel Osciak , Marek Szyprowski , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org These are signed so instead of being 1 and 0 as intended they are -1 and 0. It doesn't cause a bug in the current code but Sparse warns about it: drivers/media/video/s5p-fimc/fimc-core.h:226:28: error: dubious one-bit signed bitfield Signed-off-by: Dan Carpenter diff --git a/drivers/media/video/s5p-fimc/fimc-core.h b/drivers/media/video/s5p-fimc/fimc-core.h index e3a7c6a..7665a3f 100644 --- a/drivers/media/video/s5p-fimc/fimc-core.h +++ b/drivers/media/video/s5p-fimc/fimc-core.h @@ -222,10 +223,10 @@ struct fimc_effect { * @real_height: source pixel (height - offset) */ struct fimc_scaler { - int scaleup_h:1; - int scaleup_v:1; - int copy_mode:1; - int enabled:1; + unsigned int scaleup_h:1; + unsigned int caleup_v:1; + unsigned int copy_mode:1; + unsigned int enabled:1; u32 hfactor; u32 vfactor; u32 pre_hratio;