* [patch] i915: signedness bug in check_overlay_src()
@ 2010-10-27 21:17 Dan Carpenter
2010-10-27 21:58 ` Chris Wilson
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-10-27 21:17 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, kernel-janitors, dri-devel
"depth" should be signed in case packed_depth_bytes() returns -EINVAL.
This probably doesn't make a difference at runtime. In the original
code we would return -EINVAL later if (rec->offset_Y % 4294967274) is
non-zero.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/gpu/drm/i915/intel_overlay.c b/drivers/gpu/drm/i915/intel_overlay.c
index afb96d2..02ff0a4 100644
--- a/drivers/gpu/drm/i915/intel_overlay.c
+++ b/drivers/gpu/drm/i915/intel_overlay.c
@@ -946,7 +946,9 @@ static int check_overlay_src(struct drm_device *dev,
{
int uv_hscale = uv_hsubsampling(rec->flags);
int uv_vscale = uv_vsubsampling(rec->flags);
- u32 stride_mask, depth, tmp;
+ u32 stride_mask;
+ int depth;
+ u32 tmp;
/* check src dimensions */
if (IS_845G(dev) || IS_I830(dev)) {
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] i915: signedness bug in check_overlay_src()
2010-10-27 21:17 [patch] i915: signedness bug in check_overlay_src() Dan Carpenter
@ 2010-10-27 21:58 ` Chris Wilson
0 siblings, 0 replies; 2+ messages in thread
From: Chris Wilson @ 2010-10-27 21:58 UTC (permalink / raw)
To: Dan Carpenter; +Cc: intel-gfx, kernel-janitors, dri-devel
On Wed, 27 Oct 2010 23:17:25 +0200, Dan Carpenter <error27@gmail.com> wrote:
> "depth" should be signed in case packed_depth_bytes() returns -EINVAL.
>
> This probably doesn't make a difference at runtime. In the original
> code we would return -EINVAL later if (rec->offset_Y % 4294967274) is
> non-zero.
Applied to fixes, thanks.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-27 21:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-27 21:17 [patch] i915: signedness bug in check_overlay_src() Dan Carpenter
2010-10-27 21:58 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox