From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <error27@gmail.com>
Date: Wed, 27 Oct 2010 22:20:37 +0000
Subject: Re: [patch] nfsd: fix NULL dereference in setattr()
Message-Id: <20101027222037.GO6062@bicker>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20101027211904.GJ6062@bicker> <20101027215025.GB29477@fieldses.org>
In-Reply-To: <20101027215025.GB29477@fieldses.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Neil Brown <neilb@suse.de>, linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org

On Wed, Oct 27, 2010 at 05:50:25PM -0400, J. Bruce Fields wrote:
> On Wed, Oct 27, 2010 at 11:19:04PM +0200, Dan Carpenter wrote:
> > The original code would oops if this were called from nfsd4_setattr()
> > because "filpp" is NULL.
> 
> I believe it's impossible to reach this case: we never give out write
> delegations, so the preceding nfs4_check_delegmode will always fail when
> called from setattr.
> 
> We should do this anyway, but I'll probably queue it up for the next
> merge window.

Sounds good.  This was a static checker patch not a run time bug (as
you obviously realized).

regards,
dan carpenter