From: Dan Carpenter <error27@gmail.com>
To: Hong Liu <hong.liu@intel.com>
Cc: Alan Cox <alan@linux.intel.com>,
Anantha Narayanan <anantha.narayanan@intel.com>,
Jonathan Cameron <jic23@cam.ac.uk>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] misc/apds9802als: signedness bug in
Date: Thu, 28 Oct 2010 04:41:11 +0000 [thread overview]
Message-ID: <20101028044111.GT6062@bicker> (raw)
The error handling breaks if "ret_val" is unsigned here.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/misc/apds9802als.c b/drivers/misc/apds9802als.c
index f9b91ba..0ed0935 100644
--- a/drivers/misc/apds9802als.c
+++ b/drivers/misc/apds9802als.c
@@ -123,7 +123,7 @@ static ssize_t als_sensing_range_store(struct device *dev,
{
struct i2c_client *client = to_i2c_client(dev);
struct als_data *data = i2c_get_clientdata(client);
- unsigned int ret_val;
+ int ret_val;
unsigned long val;
if (strict_strtoul(buf, 10, &val))
reply other threads:[~2010-10-28 4:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028044111.GT6062@bicker \
--to=error27@gmail.com \
--cc=alan@linux.intel.com \
--cc=anantha.narayanan@intel.com \
--cc=hong.liu@intel.com \
--cc=jic23@cam.ac.uk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).