From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasiliy Kulikov Date: Sat, 30 Oct 2010 14:22:49 +0000 Subject: [PATCH] ipc: shm: fix information leak to userland Message-Id: <20101030142249.GA9835@albatros> List-Id: References: <1288429477-21920-1-git-send-email-segooon@gmail.com> <20101030090644.GX19804@ZenIV.linux.org.uk> In-Reply-To: <20101030090644.GX19804@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Linus Torvalds Cc: kernel-janitors@vger.kernel.org, Andrew Morton , Helge Deller , David Howells , Hugh Dickins , linux-kernel@vger.kernel.org Structure shmid_ds is copied to userland with shm_unused{,2,3} fields unitialized. It leads to leaking of contents of kernel stack memory. Cc: stable@kernel.org Acked-by: Al Viro Signed-off-by: Vasiliy Kulikov --- Compile tested. ipc/shm.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/ipc/shm.c b/ipc/shm.c index fd658a1..7d3bb22 100644 --- a/ipc/shm.c +++ b/ipc/shm.c @@ -479,6 +479,7 @@ static inline unsigned long copy_shmid_to_user(void __user *buf, struct shmid64_ { struct shmid_ds out; + memset(&out, 0, sizeof(out)); ipc64_perm_to_ipc_perm(&in->shm_perm, &out.shm_perm); out.shm_segsz = in->shm_segsz; out.shm_atime = in->shm_atime; -- 1.7.0.4