public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: Cc: [PATCH] Staging: solo6x10: Fix checkpatch errors and most
Date: Sat, 06 Nov 2010 04:05:51 +0000	[thread overview]
Message-ID: <20101106040551.GD31317@bicker> (raw)
In-Reply-To: <AANLkTikQ_a4bS6aNOfEJMgF3w_17S8RBrWx7HbpqhK0K@mail.gmail.com>

On Fri, Nov 05, 2010 at 08:08:35PM -0300, Facundo Gaich wrote:
> (Forgot to Cc this list in the original email. By the way, I sent this
> to greg@kroah instead of greg@suse, because that's what the TODO file
> said. I hope that's still ok?)
> 
> This patch fixes all errors and most warnings reported by
> checkpatch.pl for all the files in the driver.

Hi Facundo,

Your email client is mangling this patch.  It's wrapping the lines and
changing the spaces to tabs.

Please read Documentation/email-clients.txt.  Then send an email to
yourself and verify that the patch applies.  (Save it as a raw email.
cat raw_email.txt | patch -p1 -R).  Then resend and we can review it.

I didn't see the original email, but don't forget to CC Ben Collins as
well.  His email is <bcollins@bluecherry.net>.  And CC the staging list
too <devel@driverdev.osuosl.org>.

regards,
dan carpenter


  reply	other threads:[~2010-11-06  4:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-05 23:08 Cc: [PATCH] Staging: solo6x10: Fix checkpatch errors and most warnings Facundo Gaich
2010-11-06  4:05 ` Dan Carpenter [this message]
2010-11-06  8:36 ` Facundo Gaich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101106040551.GD31317@bicker \
    --to=error27@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox