[patch] Staging: speakup: free after input_unregister_device()

[patch] Staging: speakup: free after input_unregister_device()

[Dan Carpenter]

input_unregister_device() frees the device so the call to
input_free_device() is a double free.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/staging/speakup/fakekey.c b/drivers/staging/speakup/fakekey.c
index adb93f2..65b2311 100644
--- a/drivers/staging/speakup/fakekey.c
+++ b/drivers/staging/speakup/fakekey.c
@@ -62,7 +62,6 @@ void speakup_remove_virtual_keyboard(void)
 {
 	if (virt_keyboard != NULL) {
 		input_unregister_device(virt_keyboard);
-		input_free_device(virt_keyboard);
 		virt_keyboard = NULL;
 	}
 }

Re: [patch] Staging: speakup: free after input_unregister_device()

[William Hubbs]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

Hi Greg,

what is the status of this patch?  I have looked at it and should
definitely go in.  Should it go to your staging-next tree or Linus's
tree though since it is a bug fix?

Thanks,

William


[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [patch] Staging: speakup: free after input_unregister_device()

[Greg KH]

On Wed, Nov 17, 2010 at 01:42:22PM -0600, William Hubbs wrote:
> Hi Greg,
> 
> what is the status of this patch?  I have looked at it and should
> definitely go in.  Should it go to your staging-next tree or Linus's
> tree though since it is a bug fix?

It's already included in my "staging-linus" git tree that will get sent
to Linus on Friday to be included in the .37 final release.

thanks,

greg k-h