* [patch] rtc: jz4740: signedness bug
@ 2010-11-13 18:26 Dan Carpenter
2010-11-13 20:02 ` Lars-Peter Clausen
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-11-13 18:26 UTC (permalink / raw)
To: kernel-janitors
platform_get_irq() can return negatives so the rtc->irq should be signed
to handle it.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c
index 2e16f72..cfcd2da 100644
--- a/drivers/rtc/rtc-jz4740.c
+++ b/drivers/rtc/rtc-jz4740.c
@@ -42,7 +42,7 @@ struct jz4740_rtc {
struct rtc_device *rtc;
- unsigned int irq;
+ int irq;
spinlock_t lock;
};
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] rtc: jz4740: signedness bug
2010-11-13 18:26 [patch] rtc: jz4740: signedness bug Dan Carpenter
@ 2010-11-13 20:02 ` Lars-Peter Clausen
0 siblings, 0 replies; 2+ messages in thread
From: Lars-Peter Clausen @ 2010-11-13 20:02 UTC (permalink / raw)
To: kernel-janitors
Dan Carpenter wrote:
> platform_get_irq() can return negatives so the rtc->irq should be signed
> to handle it.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-By: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
>
> diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c
> index 2e16f72..cfcd2da 100644
> --- a/drivers/rtc/rtc-jz4740.c
> +++ b/drivers/rtc/rtc-jz4740.c
> @@ -42,7 +42,7 @@ struct jz4740_rtc {
>
> struct rtc_device *rtc;
>
> - unsigned int irq;
> + int irq;
>
> spinlock_t lock;
> };
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-13 20:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-13 18:26 [patch] rtc: jz4740: signedness bug Dan Carpenter
2010-11-13 20:02 ` Lars-Peter Clausen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox