* [patch] Staging: speakup: free after input_unregister_device()
@ 2010-11-12 5:08 Dan Carpenter
2010-11-17 19:42 ` William Hubbs
2010-11-17 19:51 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2010-11-12 5:08 UTC (permalink / raw)
To: kernel-janitors
input_unregister_device() frees the device so the call to
input_free_device() is a double free.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/staging/speakup/fakekey.c b/drivers/staging/speakup/fakekey.c
index adb93f2..65b2311 100644
--- a/drivers/staging/speakup/fakekey.c
+++ b/drivers/staging/speakup/fakekey.c
@@ -62,7 +62,6 @@ void speakup_remove_virtual_keyboard(void)
{
if (virt_keyboard != NULL) {
input_unregister_device(virt_keyboard);
- input_free_device(virt_keyboard);
virt_keyboard = NULL;
}
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] Staging: speakup: free after input_unregister_device()
2010-11-12 5:08 [patch] Staging: speakup: free after input_unregister_device() Dan Carpenter
@ 2010-11-17 19:42 ` William Hubbs
2010-11-17 19:51 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: William Hubbs @ 2010-11-17 19:42 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 199 bytes --]
Hi Greg,
what is the status of this patch? I have looked at it and should
definitely go in. Should it go to your staging-next tree or Linus's
tree though since it is a bug fix?
Thanks,
William
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] Staging: speakup: free after input_unregister_device()
2010-11-12 5:08 [patch] Staging: speakup: free after input_unregister_device() Dan Carpenter
2010-11-17 19:42 ` William Hubbs
@ 2010-11-17 19:51 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2010-11-17 19:51 UTC (permalink / raw)
To: kernel-janitors
On Wed, Nov 17, 2010 at 01:42:22PM -0600, William Hubbs wrote:
> Hi Greg,
>
> what is the status of this patch? I have looked at it and should
> definitely go in. Should it go to your staging-next tree or Linus's
> tree though since it is a bug fix?
It's already included in my "staging-linus" git tree that will get sent
to Linus on Friday to be included in the .37 final release.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-17 19:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-12 5:08 [patch] Staging: speakup: free after input_unregister_device() Dan Carpenter
2010-11-17 19:42 ` William Hubbs
2010-11-17 19:51 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).