From: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] nilfs2: nilfs_iget_for_gc() returns ERR_PTR
Date: Tue, 23 Nov 2010 07:22:21 +0000 [thread overview]
Message-ID: <20101123.162221.51131187.ryusuke@osrg.net> (raw)
In-Reply-To: <20101123062602.GG1522@bicker>
On Tue, 23 Nov 2010 09:26:02 +0300, Dan Carpenter wrote:
> nilfs_iget_for_gc() returns an ERR_PTR() on failure and doesn't return
> NULL.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c
> index 3e90f86..5bf426f 100644
> --- a/fs/nilfs2/ioctl.c
> +++ b/fs/nilfs2/ioctl.c
> @@ -349,8 +349,8 @@ static int nilfs_ioctl_move_blocks(struct super_block *sb,
> ino = vdesc->vd_ino;
> cno = vdesc->vd_cno;
> inode = nilfs_iget_for_gc(sb, ino, cno);
> - if (unlikely(inode = NULL)) {
> - ret = -ENOMEM;
> + if (unlikely(IS_ERR(inode))) {
> + ret = PTR_ERR(inode);
> goto failed;
> }
> do {
Good catch!
This looks an -rc1 regression brought about by replacement of the gc
iget function.
I will send this fix upstream. Thank you.
Ryusuke Konishi
next prev parent reply other threads:[~2010-11-23 7:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 6:26 [patch] nilfs2: nilfs_iget_for_gc() returns ERR_PTR Dan Carpenter
2010-11-23 7:22 ` Ryusuke Konishi [this message]
2010-11-23 7:47 ` Ryusuke Konishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101123.162221.51131187.ryusuke@osrg.net \
--to=konishi.ryusuke@lab.ntt.co.jp \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox