From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Fix sparse message rtl8192u
Date: Thu, 25 Nov 2010 05:36:27 +0000 [thread overview]
Message-ID: <20101125053626.GS1522@bicker> (raw)
In-Reply-To: <1290634903.4ced8697b0603@webmail.aliceadsl.fr>
On Wed, Nov 24, 2010 at 10:41:43PM +0100, david.chosrova@libertysurf.fr wrote:
>
>
> Hello,
>
> Fix sparse message:
>
> drivers/staging/rtl8192u/r8192U_core.c:247:1: warning: "eqMacAddr" redefined
> In file included from drivers/staging/rtl8192u/:81:81:
> drivers/staging/rtl8192u/dot11d.h:35:1: warning: this is the location of the
> previous definition
>
> if ENABLE_DOT11D is enabled eqMacAddr is defined twice.
>
It would be better to remove the #ifdef around the include "dot11d.h"
and delete this definition.
Also your email client is line wrapping on long lines and changing
tabs to spaces. Read Documentation/email-clients.txt then send an
email to yourself. Save the raw email (including email headers
and everything) then `cat email.txt | patch -p1` Resend when the
patch applies.
CC the maintainers when you resend:
Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org
regards,
dan carpenter
next prev parent reply other threads:[~2010-11-25 5:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 21:41 [PATCH] Fix sparse message rtl8192u david.chosrova
2010-11-25 5:36 ` Dan Carpenter [this message]
2010-11-25 9:39 ` david chosrova
2010-11-25 10:04 ` Dan Carpenter
2010-11-27 22:37 ` David Chosrova
2010-11-28 21:19 ` Dan Carpenter
2010-11-30 15:35 ` [PATCH] Staging: rtl8192u: remove dead code to disable dot11d David Chosrova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101125053626.GS1522@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox