From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ted Ts'o" Date: Thu, 30 Dec 2010 03:55:53 +0000 Subject: Re: [patch] ext4: checking NULL instead of ERR_PTR Message-Id: <20101230035553.GL10149@thunk.org> List-Id: References: <20100826091619.GC20072@bicker> In-Reply-To: <20100826091619.GC20072@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Andreas Dilger , Jan Kara , Christoph Hellwig , Eric Sandeen , Dmitry Monakhov , linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org On Thu, Aug 26, 2010 at 11:16:54AM +0200, Dan Carpenter wrote: > d_path() returns an ERR_PTR and it doesn't return NULL. This is in > ext4_error_file() and no one actually calls ext4_error_file(). > > Signed-off-by: Dan Carpenter Thanks, I've added this to the ext4 patch tree. - Ted