From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/4] staging: keucr: Use strncpy() instead of custom
Date: Fri, 31 Dec 2010 10:17:51 +0000 [thread overview]
Message-ID: <20101231101751.GE1886@bicker> (raw)
In-Reply-To: <1293787164-7056-3-git-send-email-martinez.javier@gmail.com>
In the original code the StringCopy() function was equivalent to
memcpy(). I don't know if the source string (which is probably not an
actual string with this code) had NULL characters but if it did, that
could cause bugs.
regards,
dan carpenter
next prev parent reply other threads:[~2010-12-31 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-31 9:19 [PATCH 2/4] staging: keucr: Use strncpy() instead of custom StringCopy() and some style cleanups Javier Martinez Canillas
2010-12-31 10:17 ` Dan Carpenter [this message]
2010-12-31 13:23 ` [PATCH 2/4] staging: keucr: Use strncpy() instead of custom Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101231101751.GE1886@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox