From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: keucr: Use memcmp() instaed of custom
Date: Sat, 01 Jan 2011 09:00:54 +0000 [thread overview]
Message-ID: <20110101090053.GG1886@bicker> (raw)
In-Reply-To: <1293823712-6273-2-git-send-email-martinez.javier@gmail.com>
On Fri, Dec 31, 2010 at 12:26:00PM -0800, Joe Perches wrote:
> On Fri, 2010-12-31 at 20:28 +0100, Javier Martinez Canillas wrote:
> if (!(!memcmp(redundant+0x0D, EccBuf, 3) &&
> !memcmp(redundant+0x08, EccBuf+0x03, 3)))
^^^ ^^^
Also we should add spaces around the '+' character. But this is dead
code anyway so let's just merge it.
regards,
dan carpenter
prev parent reply other threads:[~2011-01-01 9:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-31 19:28 [PATCH 1/2] staging: keucr: Use memcmp() instaed of custom StringCmp() and some style cleanups Javier Martinez Canillas
2010-12-31 20:26 ` [PATCH 1/2] staging: keucr: Use memcmp() instaed of custom Joe Perches
2011-01-01 9:00 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110101090053.GG1886@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox