* [PATCHv4 0/4] staging: keucr: Use memcmp() & memcpy() instead of custom String[Cmp|Copy] functions
@ 2011-01-02 22:14 Javier Martinez Canillas
2011-01-03 5:34 ` [PATCHv4 0/4] staging: keucr: Use memcmp() & memcpy() instead Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2011-01-02 22:14 UTC (permalink / raw)
To: kernel-janitors
This patchset make some cleanup to staging/keucr. Use memcmp and memcpy instead of custom functions.
Also some style cleanups recomended by Dan Carpenter, Joe Perches and Gábor Stefanik.
The patches in this patchset are the following:
[PATCH 1/4] staging: keucr: Use memcmp() instead custom StringCmp() and some style cleanups
[PATCH 2/4] staging: keucr: Use memcpy() instead custom StringCopy() and some style cleanups
[PATCH 3/4] staging: keucr: Delete StringCmp() and StringCopy custom functions
[PATCH 4/4] staging: keucr: Delete use kernel strcmp() & strcpy() from TODO file
drivers/staging/keucr/TODO | 3 +-
drivers/staging/keucr/smilecc.c | 16 ++++++---
drivers/staging/keucr/smilsub.c | 69 ++++++++++----------------------------
3 files changed, 29 insertions(+), 59 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCHv4 0/4] staging: keucr: Use memcmp() & memcpy() instead
2011-01-02 22:14 [PATCHv4 0/4] staging: keucr: Use memcmp() & memcpy() instead of custom String[Cmp|Copy] functions Javier Martinez Canillas
@ 2011-01-03 5:34 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2011-01-03 5:34 UTC (permalink / raw)
To: kernel-janitors
On Sun, Jan 02, 2011 at 11:14:25PM +0100, Javier Martinez Canillas wrote:
> This patchset make some cleanup to staging/keucr. Use memcmp and memcpy instead of custom functions.
> Also some style cleanups recomended by Dan Carpenter, Joe Perches and Gábor Stefanik.
>
> The patches in this patchset are the following:
>
> [PATCH 1/4] staging: keucr: Use memcmp() instead custom StringCmp() and some style cleanups
> [PATCH 2/4] staging: keucr: Use memcpy() instead custom StringCopy() and some style cleanups
> [PATCH 3/4] staging: keucr: Delete StringCmp() and StringCopy custom functions
> [PATCH 4/4] staging: keucr: Delete use kernel strcmp() & strcpy() from TODO file
>
Looks good. v1 made me grumpy. v2 was ok. v4 is what all patches
should look like. :)
Acked-by: Dan Carpenter <error27@gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-03 5:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-02 22:14 [PATCHv4 0/4] staging: keucr: Use memcmp() & memcpy() instead of custom String[Cmp|Copy] functions Javier Martinez Canillas
2011-01-03 5:34 ` [PATCHv4 0/4] staging: keucr: Use memcmp() & memcpy() instead Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox