From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/4] staging: keucr: Use memcpy() instead custom
Date: Mon, 03 Jan 2011 16:11:56 +0000 [thread overview]
Message-ID: <20110103161156.GA2810@joi.lan> (raw)
In-Reply-To: <1294006469-4400-3-git-send-email-martinez.javier@gmail.com>
On Sun, Jan 02, 2011 at 11:14:27PM +0100, Javier Martinez Canillas wrote:
> staging: keucr: Use memcpy() instead custom StringCopy() and some style cleanups
>
> Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
> ---
> drivers/staging/keucr/smilecc.c | 16 ++++++++++------
> 1 files changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/keucr/smilecc.c b/drivers/staging/keucr/smilecc.c
> index daf322a..5659dea 100644
> --- a/drivers/staging/keucr/smilecc.c
> +++ b/drivers/staging/keucr/smilecc.c
> @@ -182,13 +182,17 @@ BYTE *buf;
> BYTE *redundant_ecc;
> BYTE *calculate_ecc;
> {
> - DWORD err;
> + DWORD err;
>
> - err=correct_data(buf,redundant_ecc,*(calculate_ecc+1),*(calculate_ecc),*(calculate_ecc+2));
> - if (err=1) StringCopy(calculate_ecc,redundant_ecc,3);
> - if (err=0 || err=1 || err=2)
> - return(0);
> - return(-1);
> + err = correct_data(buf, redundant_ecc, *(calculate_ecc + 1),
> + *(calculate_ecc), *(calculate_ecc + 2));
> + if (err = 1)
> + memcpy(calculate_ecc, redundant_ecc, 3);
> +
> + if (err = 0 || err = 1 || err = 2)
> + return 0;
> +
> + return -1;
> }
>
> void _Calculate_D_SwECC(buf,ecc)
> --
Now it looks good.
Reviewed-by: Marcin Slusarz <marcin.slusarz@gmail.com>
prev parent reply other threads:[~2011-01-03 16:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-02 22:14 [PATCH 2/4] staging: keucr: Use memcpy() instead custom StringCopy() and some style cleanups Javier Martinez Canillas
2011-01-03 16:11 ` Marcin Slusarz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110103161156.GA2810@joi.lan \
--to=marcin.slusarz@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox